Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submission] Anjali Old Lipi for Malayalam #246

Closed
jishnu7 opened this Issue Mar 3, 2019 · 4 comments

Comments

2 participants

@Didgeridoohan Didgeridoohan self-assigned this Mar 3, 2019

@Didgeridoohan

This comment has been minimized.

Copy link
Collaborator

Didgeridoohan commented Mar 3, 2019

You might have noticed I rejected all your submitted font modules. I did this because you submitted them as separate modules. If you want to resubmit, please make a single module that includes all fonts and make it optional for the user which one to install.

This can be done with the Unity module template (with the volume key selector), by renaming the installation zip to match the desired font (only currently works when installing from recovery), by utilising a configuration file that the installation script detects, by having a separate ui script that installs with the module and can be run from a terminal emulator, etc, etc. There are several different ways to achieve this.

@jishnu7

This comment has been minimized.

Copy link
Author

jishnu7 commented Mar 3, 2019

@Didgeridoohan Unity module, like you said, requires recovery - isn't the point of magisk manager to avoid that? If there is any other option which works on magisk manager, please let me know.

@Didgeridoohan

This comment has been minimized.

Copy link
Collaborator

Didgeridoohan commented Mar 3, 2019

You might want to read my message again...

Unity does not require to be installed through recovery. If you want to use the "rename the zip for different options" way of making a user pick different fonts the module would have to be installed through recovery (since currently the Magisk Manager renames the zip prior to installing). All other options I gave you work when installing from the Magisk Manager.

@jishnu7

This comment has been minimized.

Copy link
Author

jishnu7 commented Mar 6, 2019

Thanks for the explanation. Sending unified module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.