SearchMetroTextBox style, IsReadOnly #2678

Closed
robertorp opened this Issue Sep 29, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@robertorp

What steps will reproduce this issue?

SearchMetroTextBox
I want to make it to read-only but can click on the search button.

Write problem description here
When I put the textbox to read only the same does not allow me to click the search button

Expected outcome

Write expected outcome here
Clicking the search button with the active isReadOnly property

Environment

  • MahApps.Metro v1.3.0
  • Windows 10
  • Visual Studio 2015
  • .NET Framework 4.61
@thoemmi

This comment has been minimized.

Show comment
Hide comment
@thoemmi

thoemmi Oct 6, 2016

Collaborator

@punker76 I agree with @robertorp that the clear button should be enabled even if the TextBox is readonly. Only if it's disabled, the button should be disabled too.

Currently, the button is disabled here and here respectively.

Collaborator

thoemmi commented Oct 6, 2016

@punker76 I agree with @robertorp that the clear button should be enabled even if the TextBox is readonly. Only if it's disabled, the button should be disabled too.

Currently, the button is disabled here and here respectively.

@punker76

This comment has been minimized.

Show comment
Hide comment
@punker76

punker76 Oct 6, 2016

Member

@thoemmi I'm with you with the MetroButtonTextBox but not for the textbox style, cause it clears the text if you click the button. I think this will maybe surprise the user?

Member

punker76 commented Oct 6, 2016

@thoemmi I'm with you with the MetroButtonTextBox but not for the textbox style, cause it clears the text if you click the button. I think this will maybe surprise the user?

@thoemmi

This comment has been minimized.

Show comment
Hide comment
@thoemmi

thoemmi Oct 6, 2016

Collaborator

😕 Yes, you're right. However, think of a "Browse" button. The user should not be able to enter the filename directly, therefore the textbox is readonly. But if the user clicks on the button, a File Open dialog should open.

So the button should be enabled even if the textbox is readonly, only if TextBoxHelper.ButtonCommand is set. 😎

Collaborator

thoemmi commented Oct 6, 2016

😕 Yes, you're right. However, think of a "Browse" button. The user should not be able to enter the filename directly, therefore the textbox is readonly. But if the user clicks on the button, a File Open dialog should open.

So the button should be enabled even if the textbox is readonly, only if TextBoxHelper.ButtonCommand is set. 😎

@punker76 punker76 added this to the 1.4.0 milestone Oct 28, 2016

@punker76 punker76 self-assigned this Nov 18, 2016

@punker76 punker76 closed this in 1a06904 Nov 18, 2016

@punker76

This comment has been minimized.

Show comment
Hide comment
@punker76

punker76 Nov 18, 2016

Member

@robertorp This feature will be available in 1.4.0

Member

punker76 commented Nov 18, 2016

@robertorp This feature will be available in 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment