New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetroWindow.ShowMetroDialogAsync odd behaviour with provided DialogSettings #2735

Closed
pfattisc opened this Issue Nov 4, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@pfattisc

pfattisc commented Nov 4, 2016

What steps will reproduce this issue?

Calling

var myDialogSettings = new MetroDialogSettings(){AnimateHide = false,AnimateShow = false};
metroWindow.ShowMetroDialogAsync(myDialog, myDialogSettings)

does not use the provided DialogSettings myDialogSettings. Instead the DialogSettings of the base class of myDialog are used (and these are by default AnimateHide = AnimateShow = true)

Expected outcome

I think the provided DialogSettings should be used. More over I think that the provided DialogSettings myDialogSettings should be set on the dialog instance myDialog because normally there is a close handler within myDialog that calls

metroWindow.HideMetroDialogAsync(this, this.DialogSettings);.

That way ShowMessageAsync(..) and ShowMetroDialogAsync(..) would behave equally.

See example:
ShowMetroDialogAsyncIssue.zip

--

Environment

  • MahApps.Metro v1.3.0
  • Windows 7x64
  • Visual Studio 2013
  • .NET Framework 4.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment