New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout IsPinned = False/True #2744

Closed
avechuche opened this Issue Nov 11, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@avechuche

avechuche commented Nov 11, 2016

What steps will reproduce this issue?

  1. When IsPinned="False" and ExternalCloseButton="Left", two clicks are required to give focus to a control (textbox in this case), 1 to close flyout, and 1 to focus control.

  2. When "IsPinned = True", and a control has the focus, when the flyout automatically close, the control loses focus.

Expected outcome

  1. Is it possible that with a 1 click, close the flyout and focus on the control?

  2. When closing the flyout, the control that has the focus, do not lose it.

Example
Change ".jpg" to ".zip"

ispinned

--

Environment

  • MahApps.Metro 1.3.0
  • Windows 8.1 Update 3 x64
  • Visual Studio 2016
  • .NET Framework 4.5
@Trakcf

This comment has been minimized.

Show comment
Hide comment
@Trakcf

Trakcf Nov 14, 2016

1 is the same as my #2733
Handled needs to not be set when mouse is clicked outside the flyout, what needs to change is as follows but I had just wanted to check and see if that Handled was in there for any specific reason.

if (Flyouts.OverrideExternalCloseButton == null)
            {
                foreach (var flyout in Flyouts.GetFlyouts().Where(x => x.IsOpen && x.ExternalCloseButton == e.ChangedButton && (!x.IsPinned || Flyouts.OverrideIsPinned)))
                {
                    flyout.IsOpen = false;
                    //e.Handled = true;
                }
            }
            else if (Flyouts.OverrideExternalCloseButton == e.ChangedButton)
            {
                foreach (var flyout in Flyouts.GetFlyouts().Where(x => x.IsOpen && (!x.IsPinned || Flyouts.OverrideIsPinned)))
                {
                    flyout.IsOpen = false;
                    //e.Handled = true;
                }
            }

Trakcf commented Nov 14, 2016

1 is the same as my #2733
Handled needs to not be set when mouse is clicked outside the flyout, what needs to change is as follows but I had just wanted to check and see if that Handled was in there for any specific reason.

if (Flyouts.OverrideExternalCloseButton == null)
            {
                foreach (var flyout in Flyouts.GetFlyouts().Where(x => x.IsOpen && x.ExternalCloseButton == e.ChangedButton && (!x.IsPinned || Flyouts.OverrideIsPinned)))
                {
                    flyout.IsOpen = false;
                    //e.Handled = true;
                }
            }
            else if (Flyouts.OverrideExternalCloseButton == e.ChangedButton)
            {
                foreach (var flyout in Flyouts.GetFlyouts().Where(x => x.IsOpen && (!x.IsPinned || Flyouts.OverrideIsPinned)))
                {
                    flyout.IsOpen = false;
                    //e.Handled = true;
                }
            }
@Kumar2Harsh

This comment has been minimized.

Show comment
Hide comment
@Kumar2Harsh

Kumar2Harsh Nov 30, 2017

when we make IsPinned =false or true
there is no effect in flyout

Kumar2Harsh commented Nov 30, 2017

when we make IsPinned =false or true
there is no effect in flyout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment