New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout Position top element focus inhibited by title bar #2756

Closed
economypowers opened this Issue Nov 29, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@economypowers

economypowers commented Nov 29, 2016

What steps will reproduce this issue?

Create a window with a Flyout position "Top" with a grid inside that has a control in the top row.

If you have a control that is in the top row of a grid inside a Flyout, the title bar is in the way causing issues with the control getting focus.

In the simplest example, I use a ComboBox and can only click into the list at the barest strip of the bottom of the control.

This happens even when you set the WindowCommandsOverlayBehavior to Never. I also tried to correct this by adding a top margin to the Flyout and the title bar 'dead zone' remained.

I attached a simple example that shows the issue.

Expected outcome

I would expect that the title bar area would be taken into account when the Flyout is shown on the top allowing the control it is obscuring to work properly.

A work around for the time being is in any Flyout that is position "Top" with a grid inside, too add an 'empty' row that contains a label with no content. Then the Flyout will allocate space to the top of the Flyout to account for the title bar.

--

Environment

  • MahApps.Metro __v1.3.0
  • Windows 10 and Windows 7_
  • Visual Studio 2013 Professional and Visual Studio 2015 Community
  • .NET Framework 4.5.1 and 4.5.2
    FlyoutTopIssue.zip

@punker76 punker76 self-assigned this Nov 29, 2016

@punker76 punker76 added this to the 1.4.0 milestone Nov 29, 2016

@punker76

This comment has been minimized.

Show comment
Hide comment
@punker76

punker76 Dec 6, 2016

Member

@economypowers This will be fixed in 1.4.0. The draggable area is now really only the header (the complete header now) of the Flyout itself.

/cc @thoemmi Now the complete header area is allowed to drag the window. I think this is a better solution instead to restrict it to the TitleBarHeight.

To remove the window buttons you can set WindowButtonCommandsOverlayBehavior="HiddenTitleBar" on the MetroWindow.

2016-12-06_10h03_05

Member

punker76 commented Dec 6, 2016

@economypowers This will be fixed in 1.4.0. The draggable area is now really only the header (the complete header now) of the Flyout itself.

/cc @thoemmi Now the complete header area is allowed to drag the window. I think this is a better solution instead to restrict it to the TitleBarHeight.

To remove the window buttons you can set WindowButtonCommandsOverlayBehavior="HiddenTitleBar" on the MetroWindow.

2016-12-06_10h03_05

@punker76 punker76 closed this Dec 6, 2016

punker76 added a commit that referenced this issue Dec 6, 2016

Fix #2756
  Remove old wrong draggable thumb
  Allow complete header area to drag a window
@thoemmi

This comment has been minimized.

Show comment
Hide comment
@thoemmi

thoemmi Dec 6, 2016

Collaborator

LGTM. The code is much simpler now 👍

Collaborator

thoemmi commented Dec 6, 2016

LGTM. The code is much simpler now 👍

@economypowers

This comment has been minimized.

Show comment
Hide comment
@economypowers

economypowers Dec 6, 2016

Thank you for the wonderfully fast response. I will be looking forward to the next release.

economypowers commented Dec 6, 2016

Thank you for the wonderfully fast response. I will be looking forward to the next release.

@punker76

This comment has been minimized.

Show comment
Hide comment
@punker76

punker76 Dec 6, 2016

Member

@economypowers You can use and test pre-release 1.4.0-ALPHA036

Member

punker76 commented Dec 6, 2016

@economypowers You can use and test pre-release 1.4.0-ALPHA036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment