New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Watermark Trimming #2884

Closed
amkuchta opened this Issue Mar 9, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@amkuchta
Contributor

amkuchta commented Mar 9, 2017

What steps will reproduce this issue?

Currently, any watermark applied to a TextBox or ComboBox control will not trim when the control becomes too short to display the information

Expected outcome

Text should trim at the character/word level, followed by a set of ellipses

@amkuchta

This comment has been minimized.

Contributor

amkuchta commented Mar 13, 2017

Personally, I think that the watermark should follow the same setting as the TextBox instead of having to set a separate property (if possible) @xxMUROxx, thoughts?

@xxMUROxx

This comment has been minimized.

Contributor

xxMUROxx commented Mar 13, 2017

@amkuchta

This comment has been minimized.

Contributor

amkuchta commented Mar 17, 2017

@xxMUROxx once I get #2892 done and approved / rejected, I will look at tackling this and #2889 (I added commits to the above PR that shouldn't have been there 💩 , so now I want to get it taken care of before I tackle anything else)

@xxMUROxx

This comment has been minimized.

Contributor

xxMUROxx commented Mar 17, 2017

@amkuchta You can remove the commits that are wrong on the branch representing the PR. Then you can git push -f to update the PR. Since no merge is done yet, there is no problem if you rewrite history.

@punker76 punker76 self-assigned this Mar 17, 2017

@amkuchta

This comment has been minimized.

Contributor

amkuchta commented Mar 17, 2017

@punker76 do you want me to roll this and #2889 into #2898 (I would rename the PR to "Watermark Enhancements", but this seems to fit there), or are you actively working it now?

@xxMUROxx thanks for the advice - I separated the PR, so now I can work this without any guilt 😄

@amkuchta

This comment has been minimized.

Contributor

amkuchta commented Mar 19, 2017

@xxMUROxx I mixed the TextBox and TextBlock controls up... TextBox does not have a TextTrimming property. I am integrating a new DependencyProperty to handle this.

@amkuchta

This comment has been minimized.

Contributor

amkuchta commented Mar 19, 2017

@xxMUROxx @punker76 So, if I have both TextTrimming and TextWrapping set for the watermark, TextWrapping overrides TextTrimming. Should we keep it this way, or should I make TextTrimming the dominant behavior?

@amkuchta amkuchta referenced this issue Mar 19, 2017

Closed

[RFC] [WIP] Watermark Enhancements #2898

6 of 8 tasks complete

@amkuchta amkuchta referenced this issue Apr 29, 2017

Closed

Watermark Enhancements #2948

4 of 4 tasks complete

@punker76 punker76 added this to the 1.6.0 milestone Oct 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment