New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge must have a different look when disabled #2977

Closed
xxMUROxx opened this Issue May 25, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@xxMUROxx
Contributor

xxMUROxx commented May 25, 2017

What steps will reproduce this issue?

The Badge has no diffent appearance if the object itself or any parent visual element are disabled:

Expected outcome

Badge should look different if disabled

current proposed
badge-currentbehavior badge-newbehavior

Implementation

https://github.com/xxMUROxx/MahApps.Metro/tree/feature/Badge-Disabled-Style

If desired I will create a PR with the above linked branch.

@thoemmi

This comment has been minimized.

Collaborator

thoemmi commented May 26, 2017

Can a badge be disabled? It's not interactive anyway. The number shown on the badge is still relevant.

Anyway, if a different appearance is desired, I wouldn't change the opacity but the color. The button shining through the badge in your proposal looks strange. I would prefer a solid badge background, something gray-ish maybe.

@amkuchta

This comment has been minimized.

Contributor

amkuchta commented May 28, 2017

I'm with @thoemmi (I'm glad I wasn't the only one who took issue with the button showing through). I think a grey would be awesome, but it would have to be a different grey than the control that the badge adorns

@xxMUROxx

This comment has been minimized.

Contributor

xxMUROxx commented May 29, 2017

@thoemmi since a badge has no command, yes it is not interactive. But it looks strange if the parent control is disabled and the badge has the bright color (accented if default).
I like your and @amkuchta's idea.

badgebackgroundgray

@xxMUROxx

This comment has been minimized.

Contributor

xxMUROxx commented Jul 6, 2017

@punker76 what do you think?

@punker76 punker76 added this to the 1.6.0 milestone Sep 8, 2017

@punker76 punker76 self-assigned this Sep 8, 2017

@punker76 punker76 added the enhancement label Sep 8, 2017

@punker76 punker76 closed this in 2fdb9eb Sep 29, 2017

@punker76

This comment has been minimized.

Member

punker76 commented Sep 29, 2017

@xxMUROxx I've added your changes from your branch. thx! 👍 I only renamed the brush to MahApps.Metro.Brushes.Badged.DisabledBackgroundBrush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment