New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width parse error #3043

Closed
ShannonZ opened this Issue Sep 8, 2017 · 9 comments

Comments

Projects
None yet
2 participants
@ShannonZ

ShannonZ commented Sep 8, 2017

Source code for this issue github

  • Reproduce
    capture-8

  • Expected Results
    The width of editor in different tab items should be corrected!
    If I use a standard WPF TabControl, like this:

it works fine. So I guess it's related to Mahapps, maybe due to the funny animation transition when you change tabs.

@punker76

This comment has been minimized.

Member

punker76 commented Sep 8, 2017

@ShannonZ I think this is a problem of SoftFluent.Windows. If I put a NUD in a Tab all is fine.

2017-09-08_11h33_25

@punker76

This comment has been minimized.

Member

punker76 commented Sep 8, 2017

@ShannonZ If I replace the NUD with a TextBox then I get the same result.

@ShannonZ

This comment has been minimized.

ShannonZ commented Sep 9, 2017

@punker76 In SoftFluent.Windows, the width of the second column of DataGrid was simply set to be "*". <DataGridTemplateColumn Header="Value" Width="*">
in PropertyGrid.xaml #line 219) . Nothing else was done~

@punker76

This comment has been minimized.

Member

punker76 commented Sep 9, 2017

The problem is maybe, that the second one isn't visible on start. But all this happens also without MahApps.

@ShannonZ

This comment has been minimized.

ShannonZ commented Sep 9, 2017

@punker76 I think you should using an NUD in DataGrid to reproduce this issue. And in my machine, when putting NUD in the last column of a DataGrid cell, the width seems to be not fixed.

Demo(I used SF)
Click more than one times of the "change" button, you will see the same code produce different results.
capture-9

If you start a project from scratch and add a standard WPF TabControl, like this(Should use Window instead of MetroWindow):

<TabControl>
    <TabItem  Header="SF1" >
        <windows:PropertyGrid x:Name="pg1" Grid.Column="0"  ScrollViewer.VerticalScrollBarVisibility="Auto" ScrollViewer.HorizontalScrollBarVisibility="Hidden" />
    </TabItem>
    <TabItem Header="SF2" >
        <windows:PropertyGrid x:Name="pg2" Grid.Column="0"  ScrollViewer.VerticalScrollBarVisibility="Auto" ScrollViewer.HorizontalScrollBarVisibility="Hidden" />
    </TabItem>
</TabControl>

it works fine. So I guess it's related to Mahapps, maybe due to the funny animation transition when you change tabs.

@punker76

This comment has been minimized.

Member

punker76 commented Sep 9, 2017

@ShannonZ If I deactivate the Expander MahApps style the issue is gone, so I will investigate what's going wrong with this.

@punker76 punker76 reopened this Sep 9, 2017

@ShannonZ

This comment has been minimized.

ShannonZ commented Sep 9, 2017

@punker76 Thanks for your kindness work! And the great MahApps will become more perfect.

@punker76 punker76 added Bug and removed Not a fault by MahApps labels Sep 9, 2017

@punker76 punker76 self-assigned this Sep 9, 2017

@punker76 punker76 added this to the 1.6.0 milestone Sep 9, 2017

@punker76 punker76 closed this in 6168ad5 Sep 9, 2017

@punker76

This comment has been minimized.

Member

punker76 commented Sep 9, 2017

@ShannonZ Found it. A fix will be available with 1.6.0-alpha016

@ShannonZ

This comment has been minimized.

ShannonZ commented Sep 9, 2017

great work! Can't thank you enough~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment