New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimePicker fails to parse times with an AM/PM. #3049

Closed
toddburnside opened this Issue Sep 9, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@toddburnside

toddburnside commented Sep 9, 2017

What steps will reproduce this issue?

  • Have a TimePicker with the culture set to one that uses AM/PM, such as en-US.
  • Edit the time in the TimePicker textbox.
  • Textbox will be cleared when it loses focus because the time failed to parse.

The cause of this is that "12:23:17 AM" is valid as part of a DateTime, but it is NOT valid as a TimeSpan.

Expected outcome

Times with an AM/PM parse correctly.

Repo

I don't have a repo that reproduces this, but it is simple to reproduce. Any TimePicker instance described above will do it. I will submit a PR that fixes this issue.

Environment

  • MahApps.Metro v1.6.0-alpha014
  • Windows OS 10 Pro
  • Visual Studio 2017
  • .NET Framework 4.5.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment