Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Introduce SplitButton #1138

Closed
wants to merge 9 commits into from

Conversation

QuantumDeveloper
Copy link
Contributor

Introduced new control - SplitButton

@QuantumDeveloper
Copy link
Contributor Author

image

Here is the result. @Amrykid @punker76 What do you think?

@QuantumDeveloper
Copy link
Contributor Author

Second try:

Basic:
image
Focused:
image
MouseOver:
image

@zeluisping
Copy link
Contributor

Chevron is too big. Maybe reduce size to something like 70-80%.

@amkuchta
Copy link
Contributor

I was actually thinking a small triangle might be more in line with the style of everything else in MahApps

@Sorien
Copy link

Sorien commented Mar 12, 2014

arrow is too big for sure, maybe i'd use something like this
image

@zeluisping
Copy link
Contributor

arrow

It's actually called chevron.

@QuantumDeveloper
Copy link
Contributor Author

I hope this is what you wanted?
image

@zeluisping
Copy link
Contributor

Move it a bit to the right.

_Edit:_ I mean Left.

@QuantumDeveloper
Copy link
Contributor Author

Third try:
image

@QuantumDeveloper
Copy link
Contributor Author

@Amrykid you could merge this PR.

@chandramouleswaran
Copy link
Contributor

This is good work - did you take a look at https://wpftoolkit.codeplex.com/wikipage?title=SplitButton

Wouldn't adding theme to the above make more sense than reinventing the wheel?

@zeluisping
Copy link
Contributor

@chandramouleswaran Adding a theme to a control from another library would create a dependency on said library. Creating the control makes MahApps.Metro more independent.

@QuantumDeveloper
Copy link
Contributor Author

@chandramouleswaran also their split button is not good enough for me. Thats the reason I made my splitbutton. And the quality and speed with which xceed fix bugs and update controla also non-suitable for me.

@AzureKitsune AzureKitsune mentioned this pull request Mar 16, 2014
AzureKitsune added a commit that referenced this pull request Mar 16, 2014
@QuantumDeveloper QuantumDeveloper deleted the SplitButton branch March 20, 2014 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants