Fix for FlipView : Navigation's button visibility and Transition update #2750

Merged
merged 11 commits into from Nov 22, 2016

Conversation

Projects
None yet
2 participants
@jumulr
Contributor

jumulr commented Nov 19, 2016

Refresh navigation buttons' visibility when control's orientation changes.
Handle navigation buttons' visibility when toggling their display.
Apply transition when SelectedIndex changes.

@punker76

Thx for fixing this. Can you look at my 2 comments?

+ value = ((CoerceValueCallback)item)(d, value);
+ return CoerceSelectedIndexProperty(d, value);
+ }
+ });
}

This comment has been minimized.

@punker76

punker76 Nov 19, 2016

Member

Can you add more documentation what this code does?

@punker76

punker76 Nov 19, 2016

Member

Can you add more documentation what this code does?

+ Minimum="1"
+ Maximum="{Binding Path=Items.Count, Mode=OneWay}"
+ Value="{Binding Path=SelectedIndex, Mode=TwoWay, Converter={vc:Int32IndexToNumberConverter}}"/>
+ <TextBlock VerticalAlignment="Center" Margin="8 0 0 0">

This comment has been minimized.

@punker76

punker76 Nov 19, 2016

Member

Why not starting from 0? Then you don't need the Int32IndexToNumberConverter.

@punker76

punker76 Nov 19, 2016

Member

Why not starting from 0? Then you don't need the Int32IndexToNumberConverter.

This comment has been minimized.

@jumulr

jumulr Nov 19, 2016

Contributor

You're absolutely right.
It's just that users tend to prefer message 'Viewing item 1 on 2' than 'Viewing item 0 on 1'.
Hence the shift of 1.

@jumulr

jumulr Nov 19, 2016

Contributor

You're absolutely right.
It's just that users tend to prefer message 'Viewing item 1 on 2' than 'Viewing item 0 on 1'.
Hence the shift of 1.

@jumulr

This comment has been minimized.

Show comment
Hide comment
@jumulr

jumulr Nov 19, 2016

Contributor

Here you are, i added a detail explanation of the coercion trick.
As i am totally new to GitHub, feel free to instruct me on the workflow in case i did a mistake.

Contributor

jumulr commented Nov 19, 2016

Here you are, i added a detail explanation of the coercion trick.
As i am totally new to GitHub, feel free to instruct me on the workflow in case i did a mistake.

@jumulr jumulr closed this Nov 19, 2016

@punker76

This comment has been minimized.

Show comment
Hide comment
@punker76

punker76 Nov 19, 2016

Member

@jumulr why closed?

Member

punker76 commented Nov 19, 2016

@jumulr why closed?

@jumulr jumulr reopened this Nov 19, 2016

@jumulr

This comment has been minimized.

Show comment
Hide comment
@jumulr

jumulr Nov 19, 2016

Contributor

Mistake, sorry. Is that ok ?

Contributor

jumulr commented Nov 19, 2016

Mistake, sorry. Is that ok ?

@punker76 punker76 merged commit 8e0a7db into MahApps:develop Nov 22, 2016

1 check passed

continuous-integration/teamcity Finished TeamCity Build MahApps.Metro PullRequest :: MahApps.Metro PullRequests : Tests passed: 62
Details

@punker76 punker76 added this to the 1.4.0 milestone Nov 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment