New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a few issues in ThemeManager #2992

Merged
merged 14 commits into from Jun 28, 2017

Conversation

Projects
None yet
2 participants
@batzen
Contributor

batzen commented Jun 22, 2017

  • ThemeManager did not look at merged dictionaries the way wpf did. wpf looks at them in a reverse order and so should we.
  • StringComparison should be OrdinalIgnoreCase
  • Switched to nameof instead of hard coded values
  • Switched to string interpolation instead of string.format
  • Switched to null conditional operator instead of SafeRaise
  • Added some missing documentation
  • Removed "metro" from documentation to ease sharing of code with Fluent.Ribbon

@punker76 punker76 merged commit f4bb19f into MahApps:develop Jun 28, 2017

1 check passed

continuous-integration/teamcity Finished TeamCity Build MahApps.Metro PullRequest :: MahApps.Metro PullRequests : Tests passed: 64
Details
@punker76

This comment has been minimized.

Member

punker76 commented Jun 28, 2017

@batzen 👍

@punker76 punker76 added this to the 1.6.0 milestone Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment