New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TimePicker to parse times with an AM/PM. #3050

Merged
merged 2 commits into from Sep 11, 2017

Conversation

Projects
None yet
2 participants
@toddburnside

toddburnside commented Sep 9, 2017

What Changed?

Changed TimePickerBase.OnTextBoxLostFocus() to parse the DatePickerTextBox text as a DateTime rather than a TimeSpan so that time strings with an AM/PM will be parsed correctly

Closed issues. #3049

I would have added a test, but there are currently no tests for editing the time via the textbox, and it seemed non-trivial to add.

todd

@punker76 punker76 added this to the 1.6.0 milestone Sep 10, 2017

@punker76 punker76 merged commit 3f60b85 into MahApps:develop Sep 11, 2017

1 check passed

continuous-integration/teamcity Finished TeamCity Build MahApps.Metro PullRequest :: MahApps.Metro PullRequests : Tests passed: 64
Details
@punker76

This comment has been minimized.

Member

punker76 commented Sep 11, 2017

@toddburnside thx! 👍

@toddburnside toddburnside deleted the toddburnside:fix-timepicker-parsing branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment