New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 3107. #3110

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@Nuklon
Contributor

Nuklon commented Nov 24, 2017

What changed?

Fixed NullReferenceException.

Closed issues.

#3107

Fixes 3107.
- Fixes #3107.
@Nuklon

This comment has been minimized.

Contributor

Nuklon commented Jan 10, 2018

@punker76
Could you merge this? This exception gets thrown a ton.

@punker76

This comment has been minimized.

Member

punker76 commented Jan 13, 2018

@Nuklon I need a sample which got this issue. I never saw or get this...

@punker76 punker76 self-assigned this Jan 13, 2018

@punker76 punker76 added this to the 1.6.0 milestone Jan 13, 2018

@Nuklon

This comment has been minimized.

Contributor

Nuklon commented Jan 13, 2018

It's in a large project I can't disclose. I've tried to create a basic sample of it, but if I strip out almost all code (which is a must), I can't get this error anymore (basically just mahapps and caliburn). But I can't trace it back to something specific. This relatively simple fix works and shouldn't hurt anyone.

For now I've manually removed the WindowsSettingBehaviour. I also think it'd be a nice feature to be able to decide which behaviors get added to StylizedBehaviors. Even though that's now somewhat possible, it's not that easy (and I don't need the WindowsSettingBehaviour, I store it myself already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment