New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dialogs Resource handling #3142

Merged
merged 1 commit into from Jan 11, 2018

Conversation

Projects
None yet
1 participant
@punker76
Member

punker76 commented Jan 9, 2018

What changed?

  • Create new style for Dialogs MahApps.Metro.Styles.MetroDialog and set this as default
  • Add BaseMetroDialog resources to Control styles to allow easier dialog style manipulation
  • Do not load all MahApps styles in code behind again (this is not necessary anymore, since it's now at Style level too)
  • Fix inverted Dialogs theme (the background wasn't correct)

Before

2018-01-09_23h57_45

Now

2018-01-09_23h56_31

Closes #2813

Dialog Resource handling changes
- Create new style for Dialogs `MahApps.Metro.Styles.MetroDialog` and set this as default
- Add `BaseMetroDialog` resources to Control styles to allow easier dialog style manipulation
- Do not load all MahApps styles in code behind again (this is not necessary anymore, since it's now at Style level too)
- Fix inverted Dialogs theme (the background wasn't correct)

@punker76 punker76 added this to the 1.6.0 milestone Jan 9, 2018

@punker76 punker76 self-assigned this Jan 9, 2018

@punker76 punker76 merged commit 760686e into develop Jan 11, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@punker76 punker76 deleted the feature/Fix_Dialog_Resource_Handling branch Jan 12, 2018

@punker76 punker76 added the Bug label Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment