New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overriding (Metro)TabItem controltemplate/style #3152

Merged
merged 2 commits into from Jan 15, 2018

Conversation

Projects
None yet
1 participant
@punker76
Member

punker76 commented Jan 15, 2018

What changed?

  • Remove internal close command and use the CloseTabItemAction
  • Clear style and template for TabItem to prevent nasty binding expression errors
  • Allow TabControlHelper dependency properties for TabItem too (the brushes)

Closed issues.

Closes #3129

- Remove internal close command and use the CloseTabItemAction
- Clear style and template for TabItem to prevent nasty binding expression errors
- Allow TabControlHelper dependency properties for TabItem too (brushes and Underlined property)

@punker76 punker76 added this to the 1.6.0 milestone Jan 15, 2018

@punker76 punker76 self-assigned this Jan 15, 2018

@punker76 punker76 merged commit 768fd6d into develop Jan 15, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@punker76 punker76 deleted the feature/GH-3129_TabItem_Style_and_CloseButton branch Jan 15, 2018

@punker76 punker76 added the Bug label Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment