New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Handle CloseButton together with ShowDialogsOverTitleBar #3153

Merged
merged 2 commits into from Jan 16, 2018

Conversation

Projects
None yet
1 participant
@punker76
Member

punker76 commented Jan 16, 2018

What changed?

  • Pass correct dialogs settings to HandleOverlayOnShow
  • New OwnerCanCloseWithDialog property at MetroDialogSettings which can be used to handle how the owner of the dialog can be closed.
  • New IsCloseButtonEnabledWithDialog property at MetroWindow which indicates if the close button should be enabled or not if a dialog is shown.
  • HandleOverlayOnHide sets the IsCloseButtonEnabledWithDialogPropertyKey and restores focus if needed
  • HandleOverlayOnShow sets the IsCloseButtonEnabledWithDialogPropertyKey
    Verified

Closed issues.

Closes #2882

- Pass correct dialogs settings to HandleOverlayOnShow
- New `CanCloseDialogOwner` property at `MetroDialogSettings` which can be used to handle how the owner of the dialog can be closed.
- New `IsCloseButtonEnabledWithDialog` property at `MetroWindow` which indicates if the close button should be enabled or not if a dialog is shown.

@punker76 punker76 added this to the 1.6.0 milestone Jan 16, 2018

@punker76 punker76 self-assigned this Jan 16, 2018

- CanCloseDialogOwner -> `OwnerCanCloseWithDialog`
- Add trigger for `IsCloseButtonEnabledWithDialog` at WindowButtonCommands for PART_Close button
- `HandleOverlayOnHide` sets the `IsCloseButtonEnabledWithDialogPropertyKey` and restores focus if needed
- `HandleOverlayOnShow` sets the `IsCloseButtonEnabledWithDialogPropertyKey`

@punker76 punker76 merged commit 6c58e81 into develop Jan 16, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@punker76 punker76 deleted the feature/GH-2882_ShowDialogsOverTitleBar_Window_CloseButton branch Jan 16, 2018

@punker76 punker76 added the Feature label Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment