New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HamburgerMenuItem ToolTip Implementation #3177

Merged
merged 4 commits into from Jan 25, 2018

Conversation

Projects
None yet
2 participants
@amkuchta
Contributor

amkuchta commented Jan 25, 2018

What changed?

Creates / Assigns the ToolTip DependencyProperty for HamburgerMenuItem, which will then carry over into HamburgerMenuGlyphItem, HamburgerMenuIconItem, etc.

Closed Issues

#3169

amkuchta added some commits Jan 25, 2018

Merge pull request #4 from MahApps/develop
Update forked develop from origin
@@ -162,6 +167,22 @@ public bool IsEnabled
}
}

/// <summary>
/// Gets or sets a value that specifies label to display.

This comment has been minimized.

@punker76

punker76 Jan 25, 2018

Member

Gets or sets a value that specifies tooltip to display.

This comment has been minimized.

@amkuchta

amkuchta Jan 25, 2018

Contributor

Completed in latest commit

/// <summary>
/// Identifies the <see cref="ToolTip"/> dependency property.
/// </summary>
public static readonly DependencyProperty ToolTipProperty = DependencyProperty.Register(nameof(ToolTip), typeof(string), typeof(HamburgerMenuItem), new PropertyMetadata(null));

This comment has been minimized.

@punker76

punker76 Jan 25, 2018

Member

should be typeof(object)

This comment has been minimized.

@amkuchta

amkuchta Jan 25, 2018

Contributor

Completed in latest commit

/// <summary>
/// Gets or sets a value that specifies label to display.
/// </summary>
public string ToolTip

This comment has been minimized.

@punker76

punker76 Jan 25, 2018

Member

should be typeof(object)

This comment has been minimized.

@amkuchta

amkuchta Jan 25, 2018

Contributor

Completed in latest commit

@amkuchta

This comment has been minimized.

Contributor

amkuchta commented Jan 25, 2018

@punker76 back to you!

@punker76 punker76 added this to the 1.6.0 milestone Jan 25, 2018

@punker76 punker76 merged commit b308d07 into MahApps:develop Jan 25, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@amkuchta amkuchta deleted the amkuchta:hamburgermenuitem-tooltip branch Jan 25, 2018

@punker76 punker76 added the Feature label Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment