Skip to content
Permalink
Browse files Browse the repository at this point in the history
Bug fix - Issue #53
Bug fix of a XSS issue on MailCleaner login (administration) interface. See issue #53 
The "message" parameter was only used for the logoutAction(). However, the parameter was not checked and not escaped.
  • Loading branch information
0xMentorNotAPseudo committed Oct 24, 2018
1 parent bd14a91 commit 5f90a52
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions www/guis/admin/application/controllers/UserController.php
Expand Up @@ -33,8 +33,10 @@ public function loginAction()

$request = $this->getRequest();
$form = new Default_Form_Login();
if ($this->getRequest()->getParam('message')) {
$form->addErrorMessage($this->getRequest()->getParam('message'));

// Display only loggedOut message
if ($this->getRequest()->getParam('message') == "loggedOut") {
$form->addErrorMessage(htmlspecialchars($this->getRequest()->getParam('message')));
}

if ($this->getRequest()->isPost() && $form->isValid($request->getPost())) {
Expand Down

0 comments on commit 5f90a52

Please sign in to comment.