New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe compile documentation on container start? #1138
Comments
Additional con: we will need to include sphinx in the running image and drop the two-stage build we currently have. That said, I see no decent alternative, so I agree with your proposal. |
Well, docs is still a single stage build. Spinx is already shipped with the image. Perhaps your're confused with the admin? 😁 |
Well, must be my dreams confused with reality. My bad 😄 |
Hi There, The To help with that, we are currently trying to find out which issues are actively keeping users from using In order for us to better assess this, it would be helpful if you could put a reaction on this post (use the 😃 icon to the top-right).
|
To: @kaiyou
Currently the documentation content is build into html at container build time. From that point on, it is a static website. We have the following is hard-coded:
Mailu/docs/conf.py
Lines 39 to 44 in 1a597fb
This needs to match on every release branch, so that every documentation version's container has a proper drop-down for other container
Then there is this build time parsing:
Mailu/docs/conf.py
Line 14 in 1a597fb
Current workflow
So now, at every release we need to update
docs/conf.py
for every published release branch. A bit cumbersome.Proposal
Defer building until the container starts. Move the following build and
nginx
invocation into a startup script:Mailu/docs/Dockerfile
Lines 15 to 20 in 1a597fb
And parse all the version information in
conf.py
from the environment. So that we only have to update the.env
/docker-compose.yml
on the documentation server on each release. (copy of those file live in https://github.com/Mailu/infra)+ Less maintenance
- Small downtime of the website during container updates
The text was updated successfully, but these errors were encountered: