Unbound DNS as optional service #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't upgrade the docker-compose file. (Not in the scope of this feature) - No need to use aliases. Docker already resolves to service names - Use a fixed IP range, which stays clear of the network ranges used by Docker. (172.xx.0.0/16)
- Use jinja template for configuration file (start.py) - Limit access to the Mailu subnet - Implement health checks
- Added checkbox for unbound resolver - Added subnet variable - Added dns variable which is generating the ip address based on subnet
HorayNarea
approved these changes
Oct 25, 2018
|
This looks good to me and I am so glad we landed the setup wizard. |
kaiyou
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #385 and #640. It aims to solve the problems discussed in #554.
This will add the unbound image and run it as service "resolver". It is an optional service and can only be included using the new setup application. Using the "resolver" service, will force the use of a fixed subnet. We have provided a default subnet which should stay clear of the Docker ranges.
Some key changes since the last PR #640:
$SUBNET, using jinja for config generation;smtp,fetchmail,antivirusandantispam.