New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbound DNS as optional service #681

Merged
merged 15 commits into from Oct 30, 2018

Conversation

5 participants
@muhlemmer
Copy link
Member

muhlemmer commented Oct 23, 2018

This PR supersedes #385 and #640. It aims to solve the problems discussed in #554.

This will add the unbound image and run it as service "resolver". It is an optional service and can only be included using the new setup application. Using the "resolver" service, will force the use of a fixed subnet. We have provided a default subnet which should stay clear of the Docker ranges.

Some key changes since the last PR #640:

  • Unbound is an optional optional service;
  • Unbound limits itself to allow only connections from $SUBNET, using jinja for config generation;
  • Unbound is used only on services that do lookups: smtp, fetchmail, antivirus and antispam.

obi12341 and others added some commits Feb 14, 2018

Some cleanup and changes:
- Don't upgrade the docker-compose file. (Not in the scope of this feature)
- No need to use aliases. Docker already resolves to service names
- Use a fixed IP range, which stays clear of the network ranges used by Docker. (172.xx.0.0/16)
Standarize unbound, prepare for setup inclusion
- Use jinja template for configuration file (start.py)
- Limit access to the Mailu subnet
- Implement health checks
Added unbound to setup
- Added checkbox for unbound resolver
- Added subnet variable
- Added dns variable which is generating the ip address based on subnet

@muhlemmer muhlemmer requested a review from Mailu/contributors Oct 23, 2018

Tim Möhlmann
@kaiyou

This comment has been minimized.

Copy link
Member

kaiyou commented Oct 30, 2018

This looks good to me and I am so glad we landed the setup wizard.

@kaiyou

kaiyou approved these changes Oct 30, 2018

@mergify mergify bot merged commit e9217b8 into Mailu:master Oct 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
mergify/pr Merged

@muhlemmer muhlemmer deleted the usrpro:feat-unbound-dns branch Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment