Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker image prefix in tests and setup utility #772

Merged
merged 4 commits into from Dec 31, 2018

Conversation

@daniel0611
Copy link
Contributor

commented Dec 21, 2018

As stated in #702 (comment) the docker prefix variable also has to be in the docker-compose file of the setup utility and the tests.
Sorry that i forgot them in #702 and was unresponsive for a while.
Also the default value of an empty string is provided because docker-compose is complaining that it isn't set.

daniel0611 and others added 2 commits Dec 21, 2018
I just noticed that the `none` image was used in place where `radicale` should be used. Fixed in this commit.
@muhlemmer

This comment has been minimized.

Copy link
Member

commented Dec 27, 2018

Thanks for picking this up!

daniel0611 added 2 commits Dec 31, 2018
docker-compose logs a warning if a environment variable is not set and has no default value.
This adds a default string as the default for traefik certdumper which was added in 7c7b52d.
@daniel0611

This comment has been minimized.

Copy link
Contributor Author

commented Dec 31, 2018

Just updated my branch from master

@muhlemmer muhlemmer merged commit 0c0d56c into Mailu:master Dec 31, 2018
2 checks passed
2 checks passed
Mergify — Summary 1 potential rule
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.