From ec87b60f94b647906e1a52c407c0d3e48041145a Mon Sep 17 00:00:00 2001
From: gudnuf <gudnuf21@proton.me>
Date: Tue, 14 Oct 2025 15:27:28 -0700
Subject: [PATCH] make initiate send idempotent and dont fail if melt quote is
 not UNPAID

---
 app/features/send/cashu-send-quote-service.ts | 34 ++++++++++++++++---
 1 file changed, 30 insertions(+), 4 deletions(-)

diff --git a/app/features/send/cashu-send-quote-service.ts b/app/features/send/cashu-send-quote-service.ts
index de6129c07..40046447c 100644
--- a/app/features/send/cashu-send-quote-service.ts
+++ b/app/features/send/cashu-send-quote-service.ts
@@ -318,10 +318,27 @@ export class CashuSendQuoteService {
 
     const wallet = account.wallet;
 
-    return wallet.meltProofs(meltQuote, sendQuote.proofs, {
-      keysetId: sendQuote.keysetId,
-      counter: sendQuote.keysetCounter,
-    });
+    return wallet
+      .meltProofs(meltQuote, sendQuote.proofs, {
+        keysetId: sendQuote.keysetId,
+        counter: sendQuote.keysetCounter,
+      })
+      .catch(async (error) => {
+        // Initiate send should be idempotent: if meltProofs was already called once and did not fail,
+        // then the melt quote will be pending or paid.
+        const latestMeltQuote = await wallet.checkMeltQuote(sendQuote.quoteId);
+        if (latestMeltQuote.state !== MeltQuoteState.UNPAID) {
+          console.warn(
+            'Initiate send was called but melt quote is not unpaid',
+            {
+              sendQuote,
+              latestMeltQuote,
+            },
+          );
+          return latestMeltQuote;
+        }
+        throw error;
+      });
   }
 
   /**
@@ -428,6 +445,15 @@ export class CashuSendQuoteService {
       throw new Error('Account does not match the quote account');
     }
 
+    const latestMeltQuote = await account.wallet.checkMeltQuote(quote.quoteId);
+    if (latestMeltQuote.state !== MeltQuoteState.UNPAID) {
+      // Pending and paid melt quotes should not be failed because that means the send is in progress or has already been completed.
+      // If the mint fails to pay the melt quote, then the melt quote state will be changed to UNPAID again.
+      throw new Error(
+        `Cannot fail melt quote that is not unpaid. Current state for send quote ${quote.id}: ${latestMeltQuote.state}`,
+      );
+    }
+
     const updatedAccountProofs = account.proofs.concat(quote.proofs);
 
     await this.cashuSendRepository.fail({