`titlevisible` ignored in legend customization

[icweaver]

Following up from slack, titlevisible seems to be ignored when trying the legend tweaking capabilities introduced in #291

using AlgebraOfGraphics, CairoMakie

N = 30

df = DataFrame(
	Fruit = rand(["apple", "pear", "banana", "watermelon"], N),
	Country = rand(["US", "CA", "MX"], N),
	Weight = rand(1:10, N),
)

plt = data(df) *
    mapping(:Fruit, :Weight, dodge=:Country, color=:Country) *
	visual(BarPlot)

draw(plt, legend=(position=:top, titlevisible=false))

[piever]

Related issue (cross-posting from discourse), which is probably solvable directly in AoG is to call the correct "title-free" MakieLayout Legend method when there are no titles to get the correct layout (without additional empty space).

[piever]

So, the syntax color = :Country => "" now removes "most" of the extra space associated to the title, even though a little bit remains. I suspect it is a small issue with MakieLayout correctly removing the title space but not the padding between title and entries. It could probably be easier to fix it there, so that AlgebraOfGraphics can always call the same method.

[icweaver]

Oh wow, thanks for remembering this, haha. I see what you mean, happy to close this here in favor of a future upstream fix. Thanks for pointing me in the right direction and for all of your work on this!