Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for density #211

Merged
merged 3 commits into from Jun 10, 2021
Merged

Update documentation for density #211

merged 3 commits into from Jun 10, 2021

Conversation

rikhuijzer
Copy link
Contributor

As far as I understand, using datalimits is the only way to set the density range; I couldn't get it to work with extrema.

This PR is just a temporary clarification. Maybe something with a jldoctest is better depending on how stable you expect this part of the code to be :)

@piever
Copy link
Collaborator

piever commented Jun 10, 2021

Thanks! About the doctest, the best would be to use datalimits in some plot in the docs, for example in this section. The API should be stable, because it is the same as the one used used in Makie.violin

@rikhuijzer
Copy link
Contributor Author

This is how the docs look now:

image

I'm not sure what is the cause for the discontinued line.

Setting the ylabel to nothing is just a suggestion by me. I think that most people wouldn't understand pdf and even setting it to density seems a bit verbose because it's quite obvious that it's a density plot.

@piever
Copy link
Collaborator

piever commented Jun 10, 2021

Thanks, PR looks great. You may have forgotten to push the ylabel="", but I agree it makes sense, so that people can see that it is customizable and you don't have to stick with "pdf".

It does look something is broken with the lines, do you get that weird behavior also locally? I'll look into it to try and fix it before merging this PR.

@rikhuijzer
Copy link
Contributor Author

You may have forgotten to push the ylabel=""

What do you mean?

It does look something is broken with the lines, do you get that weird behavior also locally?

It happens only locally! I've just generated the old (pre-PR) code locally and then I also get the weird behaviour. I didn't have any problems with similar plots anywhere yet, so for me this is not a problem.

I think we can merge. Let me know if there is anything to change still.

@rikhuijzer
Copy link
Contributor Author

You may have forgotten to push the ylabel=""

What do you mean?

Fixed.

@piever piever merged commit 8ef6ba4 into MakieOrg:master Jun 10, 2021
@rikhuijzer rikhuijzer deleted the patch-1 branch June 10, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants