generate edge pathes based on edge_plottype
#71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find edge paths returns `Vector{<:AbstractPath}` or
`Vector{<:Line}` based on the curvy attributes and the
`edge_plottype.`
`edge_plot` recipe allways draws `AbstractPathes` as beziersegments
even if they are just lines. If eltype of paths is `<:Line` it will use
line segments.
hexaeder
commented
Mar 21, 2022
Closed
Member
|
Sorry, forgot to give any feedback on this. This PR indeed fixed the issue we were facing with the incorrect autolimits. Thank you for implementing it! Would it be possible to tag a patch release somewhat soon so that users of Agents/InteractiveDynamics can benefit from the improvement? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this replaces #69 and fixes #64 in a much better way.
The edge pathes are determined respecting the
edge_plottypeargument. By doing so the labels, arrows and stuff are actually place along the drawn edges.@fbanning please try if this fixes your problems