Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead link in GLMakie/README.md #3539

Closed
tpgillam opened this issue Jan 8, 2024 · 3 comments
Closed

Dead link in GLMakie/README.md #3539

tpgillam opened this issue Jan 8, 2024 · 3 comments
Labels

Comments

@tpgillam
Copy link

tpgillam commented Jan 8, 2024

There is a dead link to https://github.com/MakieOrg/Makie.jl/blob/master/.github/workflows/glmakie.yaml in GLMakie/README.md. I'm not sure what the new link should be though I'm afraid.

( For context: I'm trying to run tests for a package that has a GLMakie dependency in github actions. I'm not trying to do anything other than run Aqua.jl on the package, but I believe this imports my package, and hence triggers a "no display" error. I was hoping I might find some hints in this linked file. )

@tpgillam tpgillam added the bug label Jan 8, 2024
@jkrumbiegel
Copy link
Member

Thanks for the notice, the contents of that file were recently merged into this file here https://github.com/MakieOrg/Makie.jl/blob/master/.github/workflows/reference_tests.yml#L65

@tpgillam
Copy link
Author

tpgillam commented Jan 8, 2024

Thanks @jkrumbiegel !

FYI, In my case it ended up being sufficient to just add the following clause to my julia-runtest step:

- uses: julia-actions/julia-runtest@v1
  with:
    prefix: xvfb-run

which I found suggested in the julia-runtest README, in case you wanted to link to it in the (GL)Makie readme.

@jkrumbiegel
Copy link
Member

closed in b833443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants