Tracking plot types that don't yet have all `lift`s linked to the plot object

[asinghvi17]

A while ago we introduced a mechanism to track Observable pipelines (created by lift, map, on, and onany) and associate them with a plot so that they get garbage collected along with that plot. This is done by providing the plot as the second argument to the function, for example lift(f, plot::Plot, args...).

Most Makie recipes have already transitioned, however some still have to add this tracking. It's as simple as adding the plot (or whatever name the plot! function has it under) as the second argument to the lift or similar functions within plot!.

Specifically,

- lift(x, y, z) do x, y, x
+ lift(plot, x, y, z) do x, y, z
...
end

or

- lift(some_function, x, y, z)
+ lift(some_function, plot, x, y, z)

I made a PR to do this for contour in #4303, which could be a nice reference.

• contourf
• hspan/vspan
• scatterlines
• series
• timeseries
• tricontourf
• volumeslices

All the recipes can be found in https://github.com/MakieOrg/Makie.jl/tree/master/src/basic_recipes

Inspired by #4302

[tuncbkose]

Is that to-do list accurate/up-to-date? I'm not too familiar with Makie/Julia, which is why I'm in a good first issue, but I could only find 2 untracked instances of those functions:

Makie.jl/src/basic_recipes/hvspan.jl

Line 49 in 8617742

onany(limits, p[1], p[2], mi, ma, transf) do lims, lows, highs, mi, ma, transf

and

Makie.jl/src/basic_recipes/timeseries.jl

Line 43 in 8617742

on(plot.signal) do x

The rest seem already updated, for example with commit dafd4d3 in #2731.

[asinghvi17]

Welcome to the community!

Thanks for catching that - it looks like contourf and tricontourf are both OK, I probably included them mistakenly. Series also looks fine.

You mentioned hvspan and timeseries already, but there are a few more:

Volumeslices

Makie.jl/src/basic_recipes/volumeslices.jl

Line 27 in 8617742

bbox = map(x, y, z) do x, y, z

(this is a bit tricky, it looks like a regular map but x, y, z are observables. Feel free to change the function invocation to lift for clarity)

Scatterlines has quite a few, the below statement and friends

Makie.jl/src/basic_recipes/scatterlines.jl

Line 39 in 8617742

map!(real_markercolor, p.color, p.markercolor) do col, mcol

[simonsteiger]

I'd be interested in helping out as someone with little experience in Makie's internals.

I recall looking at the sankey recipe a few weeks ago and seeing the lift function in there, too. I know that this recipe is not integrated with Makie yet and might be of low priority, but I have to plot sankeys too often and like Makie's layouting too much to not have a try.

Would it be correct to pass lift(plot, x, y, z) there, too?