Clipping defaults changed when upgrading to GLMakie v0.11 [noticed in Brillouin.jl]

[kbarros]

• Upgrading from v0.10.18 to v0.11.2
• Yes
• Mac M1

The package Brillouin.jl includes an extension for Makie plotting. Brillouin.jl uses Makie.Axis3 to create its scene, and it seems that camera defaults may have changed when moving from Makie 0.10 to 0.11. In particular, executing this code from the Brillouin docs,

using Brillouin # Might need CompatHelper branch for updated Makie
using GLMakie
sgnum = 227
Rs = [[1,0,0], [0,1,0], [0,0,1]] # conventional direct basis
kp = irrfbz_path(sgnum, Rs)
pGs = basis(kp)      # primitive reciprocal basis associated with k-path
c = wignerseitz(pGs) # associated Brillouin zone
Pᶜ⁺ᵏ = plot(c, kp)

introduces some clipping with the default camera on Makie 0.11.2:

Zooming out (e.g., with the scroll wheel) would remove the clipping.

This seems to be the relevant Axis3 initialization code from Brillouin.jl (source)

    f[1,1] = ax = Makie.Axis3(f;
        aspect=:data,
        viewmode=:fit,
        xautolimitmargin=(0f0,0f0), yautolimitmargin=(0f0,0f0), zautolimitmargin=(0f0,0f0),
        axis...)

[ffreyer]

We added clipping at the Axis3 boundary. With 0 margin you end up with lines right on the clipping boundary:

We should probably nudge them a bit further outside to prevent this.

Options to (temporarily) fix this:

• add a tiny amount of margin. Even 1f-6 is enough for me
• overwrite clipping (which I wouldn't recommend unless you want to be able to draw outside the axis frame) plot!(ax, ..., clip_planes = Plane3f[])

[ffreyer]

Hmm, seems like this is also specifically lines. The clipping code for that is different so I guess it's no surprise that it has different behavior at float eps.

[kbarros]

There is also something wrong with the margins of the 2D Axis, as constructed here: https://github.com/thchr/Brillouin.jl/blob/7defcdc7a027d948fda9fbaf39a592ddd0697001/ext/BrillouinMakieExt/wignerseitz.jl#L65-L68

Consider this code:

using Brillouin, GLMakie
Rs = [[1.0, 0.0], [-0.5, √3/2]]
cᴿ = wignerseitz(Rs)
Pᴿ = plot(cᴿ)

On GLMakie 0.11, it gives this:

The lines show artifacts, like variable thickness. Removing the "autolimitmargin" options produces a much better image:

[ffreyer]

In that case you're hitting the scene boundary. I don't think there were any changes to that.

Since you're making a full figure you could also keep the autolimitmargin and adjust figure_padding instead. Or use a Scene directly, i.e. Scene(camera = cam2d!/cam3d!)

[kbarros]

In my tests, the autolimitmargin options don't seem to do much (besides triggering these artifacts on the Makie 0.22 upgrade), so it looks like they can just be removed: thchr/Brillouin.jl#38.