Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zoom! method, cleanup #1247

Merged
merged 4 commits into from
Aug 24, 2021
Merged

Fix zoom! method, cleanup #1247

merged 4 commits into from
Aug 24, 2021

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Aug 21, 2021

See #1236

  • fix zoom!(scene, zoom_step) method for Camera3D
  • call update_cam! after translate_cam!, rotate_cam! and zoom!
  • cleanup/update some dosctrings

SimonDanisch
SimonDanisch approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@SimonDanisch SimonDanisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if it works :)

@ffreyer ffreyer merged commit f2857b0 into MakieOrg:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonDanisch SimonDanisch SimonDanisch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ffreyer @SimonDanisch