Implement time axis #1347

SimonDanisch · 2021-09-29T15:46:37Z

I noticed, that we can hack together a simple time aware axis as a small wrapper type around Axis...
We may even be able to integrate this into the Axis code itself, so that we don't need a wrapper, and the axis will just change to the correct conversion + formatting functions, depending on what you plot into it.

This would basically add a pre convert_arguments conversion, that is axis aware and can store axis local state (e.g. target unit, target range, etc).

We could also use this for categorical values and Float32 conversion, I think.
Still pretty early to tell, but I will use the TimeAxis wrapper to figure out the interface and add tests + proper error handling for the myriad of time conversions we may run into.
If this works out nicely, we can think about removing TimeAxis and add it to the standard Axis code.

But the simple mvp already works as intended:

f = Figure()
ax = TimeAxis(f[1,1])
scatter!(ax, rand(Hour(1):Hour(1):Hour(20), 10), 1:10)
f

scatter!(ax, rand(Second(1):Second(60*60):Second(20*60*60), 10), 1:10)

This currently uses promote_type to figure out the conversion target, which isn't ideal since we should rather chose the unit from the range of time values we want to display...

ffreyer · 2021-10-01T17:45:31Z

Ultrafast laser pulses seem to be resolved on a fs scale, so maybe it's worth going down to that level?
For reference:
https://www.newport.com/n/ultrafast-pulse-characterization
https://www.dickinson.edu/download/downloads/id/25/ultrafastlaserpulses

SimonDanisch · 2021-10-04T14:52:11Z

Yeah makes sense - that was just an oversight ... Still getting familiar with Unitful.jl and how to discover things...

src/makielayout/layoutables/time_axis.jl

SimonDanisch · 2021-10-07T09:19:14Z

I first wanted to implement this as unobtrusive as possible by introducing a new axis wrapper type (TimeAxis), but the more I worked on the implementation, the clearer it became, that the wrapper isn't needed at all and that I really just need to spice up the tick formatter a bit to integrate this into the standard axis.
At that point it seemed pretty silly to not do that, since then we'd introduce a new TimeAxis type, just to deprecate it a few versions later...
It will also be very easy to add new Tick types e.g. for categorical values etc...

This is pretty close to being mergeable:

new axis conversion & tick formatter finding API
Unitful integration, introducing a UnitfulTicks type, that gets chosen for x/yticks whenever you plot unitful numbers to either axis
some tests
clean up & document new APIs

visr · 2021-10-11T15:55:14Z

Great to see this! (I assume this) fixes #442.

…into sd/time-axis

laborg · 2022-01-14T10:14:49Z

Great work! I consider dropping Plots for Makie if this lands. Any time prediction on when this will happen?

SimonDanisch · 2022-01-14T13:43:31Z

In principle this PR is feature complete and works, but I will need some more time to finish up developer docs and clean up some hacks.
E.g., I noticed that this PR doubles CI times for docs and adds at least 10min to the tests...Which is pretty unacceptable and I need to debug why that happens...
Also, the conversion pipeline got even more confusing and I still hope to find a cleaner implementation for the axis converts.

SimonDanisch · 2022-01-14T14:04:58Z

Although, I just noticed, that RPRMakie goes from 5min to 23min... Which is a bit suspicious, since the one test right now in RPRMakie is super simple, and seeing that Makie CI is even faster than in other PRs, this all doesn't make much sense :D Maybe it's just a fluke of the CI.
I also just tested this code piece, which should give a good idea of any large scale regression, and that comes out with exactly the same number as on master (1s faster even):

 @time begin
       using GLMakie
       display(scatter(1:4))
       end

So maybe this was really just a CI fluke, or there is one super slow code path - both should be good news, since those should then be much easier to fix than all of Makie becoming much slower (by the new deps, or new type unstable code).

SimonDanisch · 2022-01-14T14:44:49Z

Aha...restarting the CI:

Other PRs are also around 20 min, so seems really just like a fluke :)

rapus95 · 2022-01-18T10:59:14Z

If I wanted to use/test this already, what would be the easiest way to do so? It'd be so cool if there was an insider/experimental release.

Edit: Regarding the

Also, the conversion pipeline got even more confusing and I still hope to find a cleaner implementation for the axis converts.

What's the circumstance with that? Maybe a new perspective might help 🙈 😀

jeremiedb · 2022-07-12T06:34:02Z

@SimonDanisch Sorry for the bump, I was wondering if there was anything left blocking? Having direct support for dates would be great feature!

uniment · 2022-09-23T06:10:45Z

Ultrafast laser pulses seem to be resolved on a fs scale, so maybe it's worth going down to that level? For reference: https://www.newport.com/n/ultrafast-pulse-characterization https://www.dickinson.edu/download/downloads/id/25/ultrafastlaserpulses

Considering that quantities measured in femtoseconds generally don't require use of the Julian calendar, you can probably make do without femtosecond support here. fwiw

MakieBot · 2022-11-14T13:53:55Z

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))

	using	create	display	create	display
GLMakie	32.04s (31.81, 32.22) 0.15+-	16.25s (16.17, 16.33) 0.06+-	15.03s (14.92, 15.27) 0.12+-	12.13ms (11.83, 12.32) 0.17+-	138.41ms (134.74, 141.10) 2.30+-
master	31.52s (31.14, 31.65) 0.17+-	16.26s (16.17, 16.40) 0.08+-	15.24s (15.08, 15.36) 0.10+-	11.90ms (11.72, 12.11) 0.14+-	135.09ms (132.00, 136.43) 1.47+-
evaluation	+1.63%, 0.52s slower X (3.20d, 0.00p, 0.16std)	-0.07%, -0.01s invariant (-0.16d, 0.77p, 0.07std)	-1.37%, -0.21s faster ✓ (-1.89d, 0.00p, 0.11std)	+1.86%, 0.23ms slower X (1.43d, 0.02p, 0.16std)	+2.40%, 3.32ms slower X (1.72d, 0.01p, 1.88std)
CairoMakie	30.78s (30.55, 31.01) 0.16+-	18.20s (18.07, 18.31) 0.10+-	2.80s (2.76, 2.84) 0.03+-	12.51ms (12.39, 12.64) 0.08+-	4.88ms (4.78, 4.93) 0.05+-
master	30.41s (30.11, 30.81) 0.23+-	17.94s (17.73, 18.10) 0.11+-	2.75s (2.72, 2.80) 0.03+-	12.48ms (12.14, 12.81) 0.21+-	5.02ms (4.86, 5.52) 0.23+-
evaluation	+1.22%, 0.38s slower X (1.87d, 0.01p, 0.20std)	+1.40%, 0.26s slower X (2.40d, 0.00p, 0.11std)	+1.59%, 0.04s slower X (1.42d, 0.02p, 0.03std)	+0.20%, 0.02ms invariant (0.15d, 0.78p, 0.15std)	-2.82%, -0.14ms invariant (-0.84d, 0.16p, 0.14std)
WGLMakie	37.46s (37.18, 37.75) 0.24+-	19.22s (19.11, 19.30) 0.07+-	23.31s (22.91, 23.53) 0.21+-	14.44ms (13.53, 15.24) 0.69+-	2.36s (2.01, 2.61) 0.19+-
master	37.16s (37.07, 37.22) 0.06+-	19.85s (19.65, 20.02) 0.15+-	23.51s (23.16, 23.98) 0.28+-	14.53ms (14.12, 15.29) 0.38+-	2.37s (2.33, 2.48) 0.05+-
evaluation	+0.79%, 0.3s slower X (1.67d, 0.02p, 0.15std)	-3.30%, -0.63s faster ✓ (-5.55d, 0.00p, 0.11std)	-0.84%, -0.2s invariant (-0.80d, 0.16p, 0.24std)	-0.63%, -0.09ms invariant (-0.16d, 0.77p, 0.53std)	-0.67%, -0.02s invariant (-0.11d, 0.84p, 0.12std)

SimonDanisch · 2023-09-11T17:04:50Z

Closing in favor of #3226

* take over most of the work from #1347 * add typed argument conversion (#3565) * add typed argument conversion * fix volume * add function to get available conversions * make conversion apply more narrowly * more cleanly separate recursion in convert_arguments * clean up * allow to get axis before creating a plot * clean up * fix tests * bring back dim converts (axis_convert) * update tests * fix tests and work around conversion problems * fix WGLMakie * fix errors * clean up conversion pipeline * fix tests * add changelog entry * disable project run * improve performance slightly * might as well use array * tmp * wip * implement axis convert recursion * fix tests * fix datashader * fix datashader * move unitful integration * fix performance regression!? * fix merge & new date time improvements * fix scaling test * remove test false * clean up * converts shouldnt be here * move axis converts to scene * further refactor [skip ci] * finish refactor for AxisConversion type * allow limit setting and ticks * make tests less noisy * cleanup * clean up and fix unitful/date conversion * make sure all tests work correctly * remove rand * rename, clean up and make axis spec work * clean up and test new conversion pipeline * undo feature deletion, don't reintroduce Rect2f * be explicit about Volume Interval types * minor docstring cleanup * try to clarify new conversion docstrings * remove convert_arguments_typed in favor of types_for_plot_arguments * fix remaining bugs for conversion simplification * fix ticks not updating * fix specapi * fix qqnorm * clean up types_for_plot_arguments * fix tuple conversion * try to fix compile time regression * try to fix compile time regression * clean up and introduce expand_dimensions * fix #3655 and clean up convert_arguments + add tests * fix #3509 and add tests for * clean up observables and more docs * final rename * fix docs * cleanup * small clean up * small doc improvements * improve docs * fix docs * try relative link * try without .md * take out link * try fix --------- Co-authored-by: ffreyer <frederic481994@hotmail.de>

* run CI against this PR * bump version * fix circular reference * remove GeoInterfaceMakie tests for good to avoid circular dependencies * add poly1 * Rework line shaders for WGLMakie compatability (#3558) * prototyping * fix joint with non-uniform linewidths * fix transform * add patterns * fix pattern sampling * fix truncated join cutoff + some cleanup * improve pattern overwrite threshhold * reorganize code * cleanup * add function for line vec -> line normal * don't try to cleanup joints if linewidth difference is critical * rename some variables * cleanup comments, restructure linewidth sdf generation * minor cleanup + notes * fix orientation problems with truncated joints * minor performance tweaks + cleanup * handle line joints in fragment shader & ditch variable linewidths * improve truncation overlap/gap * improve pattern adjustments for truncated joints * cleanup * reorganize code to reduce memory usage * mostly fix gap in sharp joints * explain pattern overwrite a bit more * use new fragment shader for linesegments * disable debug rendering * fix incorrect line placement * adjust line segments to pattern * use const over define & fix dots * tweak debug rendering * make truncation overlap a bit nicer * minor cleanup * fix linestyle in linesegments * skip rendering at 0 linewidth * add slight bias to avoid missing pixels * differentiate different segments in debug render * make color interpolation continuous at joint * fix dense line color artifacts * remove unused * allocate space for joints * use sdf for AA + debug render * add miter joints * handle colors * some cleanup + linesegments prep * fix some errors [skip ci] * add patterns * clean up linesegments * add normal rendering mode * minor cleanup * experiment with geometry adjustments * use rounding to solve joint over/underdraw * WebGL doesn't like scaling * smooth out inner edge of truncated join * remove derivative to reduce float accuracy issues * improve thin lines * fix lastlen error * match buffer sizes to number of drawn segments * avoid dissipation of lines at high point densities * calculate uv from quad_sdf1 * reduce number of interleaved buffers * fix disappearing grid lines * fix missing preprocessors * fix pattern artifacts in dense line sections * cleanup some variables * allow patterns to adjust to linewidth * fix AA at line end * fix nan handling * discard fully transparent pixels * fix patterns with nan, reset pattern on nan * fix size issues * extrude lines slightly to cleanly close them * fix pixel skipping? * cleanup patterns * remove linewidth from pattern based line adjustments * consider AA in shape factor * reset shape_factor if pattern changes segment shape * minor cleanup * apply changes to WGLMakie + cleanup * cleanup pattern overwrite * use the same AA_RADIUS in fragment shader * fix linelen transform * disable debug * fix line start/end AA * fix px_per_unit? * fix px_per_unit? * reduce line start/end extrusion * simplify extrusion and shape_factor * summarize breaking changes * move miter joint test * update docstring * minor cleanup * enable more tests * move gappy & friends to Makie * note change to linestyle scaling * cleanup * fix line start/end AA * remove global var * disable GeoMakie tests for now * improve transparency for WGLMakie * fix problems with 180° change in line direction * fix directionality * interpolate colormap in fragment shader * remove util.vert from line/segments --------- Co-authored-by: SimonDanisch <sdanisch@protonmail.com> * fix line inversion (#3651) * fix lines shader * cleanup debug code * fix rebase error * fix pattern connectivity * some cleanup * apply changes to WGLMakie * add test * fix CairoMakie too * update changelog * fix missing start/end segment * Update CHANGELOG.md * update comments --------- Co-authored-by: Simon <sdanisch@protonmail.com> * Documented / validated plot attributes (#3626) * add second `@recipe` method * rename function * implement recipe and keyword validation * fix some bugs * rename for clarity * change Scatter recipe * use argument symbols correctly * change Lines * change linesegments * do a bunch of plots more * fix text bugs * splice in internal attribute after mesh creation * add allowlist * fix text * add attribute deprecation mechanism * add explanation * remove `text` for GLMakie * fix contour volume attributes * add rasterize to allowlist * add `enable_depth` to volume * add `matcap` to mesh * set `fxaa = false` on scatter, lines, linesegments, text * move fxaa after mixins * fix keywords * remove markersize attribute * remove invalid markersize * add depthsorting to attributes for scatter * fix forwarded attributes * add absorption to volume * don't use `used_attributes` for datashader canvas convert * fix positional args * image * add better printing and rudimentary tests * make allowlist a tuple for fewer allocations * attribute names tuple instead of set * make deprecations also a tuple * avoid intermediate vector to speed up attribute creation * apply same optimization to blocks * implement mechanism to augment user docstring * delete manually written out attribute docs * use funcsym in docstring * incorporate attribute docs into docstring again * use equal * add changelog * introduce `DocumentedAttributes` with macro * add function to access `DocumentedAttributes` of a recipe * fix module mutation problem for now * move definition behind PlotType * return Attributes instead of Dict * convert wireframe recipe * close over reference * don't include prereleases in benchmark, failed with 1.11 alpha * stringify default expr * convert arrows * add docs * directly convert default exprs to strings * convert ablines * print wrong attribute in red * convert annotations * convert arc * remove attributes in arrows docstring * convert band * fix escaping issue * convert barplot * convert bracket * fix barplot usage in hist * convert contourf * typo * convert contour * fix waterfall * comment out arrows test * convert datashader * convert errorbar and rangebar * convert hvlines * convert hvspan * convert pie * convert rainclouds * convert scatterlines * convert series * convert spy * convert stairs * convert stem * convert streamplot * convert timeseries * convert tooltip * convert tricontourf * add transformation to allowlist * convert triplot * convert volumeslices * convert voronoiplot * convert waterfall * convert boxplot * convert crossbar * convert density * convert qqplot and qqnorm * convert ecdfplot * convert hexbin * convert hist * convert violin * improve error message printing * add docstrings for mutating functions and plot types * add missing docstrings * reconnect lines docstring * move functions out of macro * fix arrows example and adjust docs * put necessary functions back into macro --------- Co-authored-by: Simon <sdanisch@protonmail.com> * Add voxel plot type (#3527) * create voxel rendering prototype * enable lighting * prototype voxel id generation & color handling * add is_air attribute * prototype texture mapping * fix shader reloading * fix texture mapping * implement local updates * optimize render order (depthsorting = false) * add depthsorting = true * render z planes first * add lowclip and highclip * add refimg tests + some fixes * fix colorrange * fix local chunk update * handle colorrange more efficiently * handle voxel id data more efficiently * docstring & formatting * switch back to lrbt order for uvmap * add docs * try fix tests * fix show * fix test? * add missing dimensions * add arguments for placement and scale * allow Colon * add Colon() to local_update * minor cleanup * prototype WGLMakie version * add fallback in CairoMakie * add RPRMakie fallback * skip invisible voxels * fix typo * rename voxel -> voxels * update docs, fix placement * update news * fix Colorbar for voxels * enable tests * fix texture rotation * cleanup print * cleanup comment * generalize array access * debug WGLMakie * get voxels rendering in WGLMakie * fix texture mapping * activate tests * fix moving planes, cleanup prints * add unit tests * add gap attribute * tests & docs * mention potential issues with picking * fix WGLMakie picking * fix depthsorting/gap handling * switch to integer mod * fix render order * use RNG * fix 1.6 3d array syntax * fix refimage * Update CHANGELOG.md * fix julia 1.6 --------- Co-authored-by: Simon <sdanisch@protonmail.com> * implement Float32 without losing Float64 precision (rebased) (#3681) * implement float64 precision * remove merge conflicts * update CairoMakie * move some code around * simplify syntax * add non-Observable apply_transform_and_f32_conversion * clean up convert_arguments * update WGLMakie * fix tests * patch model to act after f32convert * fix function name * update project and plot_to_screen * fix patch_model * add first test * rename file * fix type after patch_model * fix ticks beyond limits * fix image and heatmap conversion * convert to float types * update test * Fix CairoMakie not precompiling missed a `Makie.` in the image recipe * update mesh converts * fix poly convert type * fix dict access * fix first test in WGLMakie * don't use triangle_mesh * fix incorrect convert_arguments * fix test * fix DataInspector error * add meshscatter + surface to tests, fix convert_arguments for poly * Fix docs + Makie tests * Fix 1.6!? * fix picking test * update DataInspector * fix indicator rotation for meshscatter in DataInspector * fix Vector{<: Integer}, Vector{Float32} -> Vector{Float32} [skip ci] * fix stackoverflow on mixed tuple types [skip ci] * fix tuples correctly [skip ci] * fix geom -> points eltype [skip ci] * fix geom -> PointBased output type * fix Rect2 -> points output type [skip ci] * fix PointBased mesh conversion * fix PointBased multi-linestrings type [skip ci] * update bezierpath * split up conversions * fix missing Points convert [skip ci] * fix CellGridBased types [skip ci] * always convert volumes to float32 * start adding type tests for every convert_arguments * fix tests * undo splitting conversions.jl * test and cleanup mesh conversions * fix docs * update & test Annotations * update & test arrows * update and test band and bracket * update & test errorbars and rangebars conversions * test & update series converts * make type stable on 1.6 * update & test remaining convert_arguments * fix & test model application * add tests for float32convert * at floatmin/max refimg test * fix typo * update text bbox test & add backtrace * avoid Float32 in data_limits * fix Polygon -> Bezierpath conversion * fix WGLMakie meshscatter model patching * fix Float64 normals * fix Float64 matrices in Voxels * test normal and uv types * fix for 1.6 * make new project method more complete * clean up some TODOs * restore text tests * restore Polar transform tests * avoid BBox for Axis limits * fix rectangle zoom, deprecate to_world with matrix inputs * fix 1.6 * fix Float64 latexstrings * fix hvlines, hvspan, errorbars, rangebars * fix & test ablines * fix other usage of projview_to_2d_limits * remove dublicated line * update changelog + cleanup [skip ci] * fix missing to_value * consider markersize and offset for scatter data_limits * fix tests * revert BBox -> Rect2d changes * get hist and barplot working --------- Co-authored-by: ffreyer <frederic481994@hotmail.de> Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com> * Document conversion pipeline (#3719) * document conversion pipeline * fix doc build * fix block --------- Co-authored-by: SimonDanisch <sdanisch@protonmail.com> * Deprecate `rotations` for `rotation` for Scatter and MeshScatter (#3724) * deprecate `rotations` for `rotation` for Scatter and MeshScatter * one more rename * remove double conversion * fix cairomakie meshscatter * fix usage in docs * remove mat4 code again * fix CairoMakie rror * change one more rotations * fix WGLMakie * add changelog entry --------- Co-authored-by: ffreyer <frederic481994@hotmail.de> * fix merge * update scatter boundingbox (#3716) * implement scatter boundingbox with marker metrics * add tests * always consider marker rotations * update changelog [skip ci] * fix data_limits * fix some more issues * rotations -> rotation * Update boundingboxes.jl --------- Co-authored-by: Simon <sdanisch@protonmail.com> * Change how boundingbox(::Text) is deprecated (#3723) * change how boundingbox is deprecated * update changelog * fix test errors * fix docs errors and cleanup error message * fix type instability * fix function name * fix function name * fix boundingbox overwrites * update changelog * add types to function args maybe this allows boundingbox(::MyPlot, space) to work without ::Symbol... * fix typing * fully remove :world space * fix test * Various fixes for next release (#3731) * fix error for 2d meshscatter data_limits * avoid Rect3(::Rect2) constructor * allow :inspector_label * allow inspector_clear and inspector_hover too * fix rect zoom & cleanup to_world * move inspector attributes to default attributes * fix NaN handling in limits & deprecate _update_rect * Update CHANGELOG.md * Fix some issues with voxels (#3748) * fix single color * update to new attribute docs and hide internal attributes * fix missing voxel planes in Axis3 * use transformationmatrix * should be normalized * make view_direction optimization less error prone * Fix rare missing/duplicate pixels in truncated joint (#3794) * rework truncated joint discard * update WGLMakie * fix non-solid linestyle joints * Add linecaps and jointstyles (#3771) * add attributes * prototype linecap & linestyle in GLMakie * move code around, add comments * add capstyle for linesegments * update WGLMakie * revert change in padding of uncapped lines * make sure truncation can't trigger * update CairoMakie * add :bevel * make miter_limit adjustable * capstyle -> linecap * update changelog * add refimg tests * add example * fix rendering issue with bevel for continued lines * use named constants * add more space to test * consider miter_limit in CairoMakie as well * also enable refimg test * switch to angle based miter_limit * fix default * tweak tests * note change in default miter_limit * add new attributes to recipes * rename jointstyle -> joinstyle * update a few more jointstyles * Fix rare missing/duplicate pixels in truncated joint (#3794) * rework truncated joint discard * update WGLMakie * fix non-solid linestyle joints * improve truncated linecap a bit * regenerate wglmakie bundled * tweak shape_factor * restore file * try fix connected sphere * add debug refimgs * more testing * more testing * revert debugging * fix test? * Cleanup for breaking 0.21 (#3765) * cleanup temp defitions * finalize data_limits cleanup * GeometryBasics should probably be breaking * adjust other versions * use newly tagged GeometryBasics * use breaking gridlayoutbase * try updating registry * somehow this is needed?! * add to missing CI --------- Co-authored-by: SimonDanisch <sdanisch@protonmail.com> * Unit support for Axes & Recipes, a.k.a axis converts (#3226) * take over most of the work from #1347 * add typed argument conversion (#3565) * add typed argument conversion * fix volume * add function to get available conversions * make conversion apply more narrowly * more cleanly separate recursion in convert_arguments * clean up * allow to get axis before creating a plot * clean up * fix tests * bring back dim converts (axis_convert) * update tests * fix tests and work around conversion problems * fix WGLMakie * fix errors * clean up conversion pipeline * fix tests * add changelog entry * disable project run * improve performance slightly * might as well use array * tmp * wip * implement axis convert recursion * fix tests * fix datashader * fix datashader * move unitful integration * fix performance regression!? * fix merge & new date time improvements * fix scaling test * remove test false * clean up * converts shouldnt be here * move axis converts to scene * further refactor [skip ci] * finish refactor for AxisConversion type * allow limit setting and ticks * make tests less noisy * cleanup * clean up and fix unitful/date conversion * make sure all tests work correctly * remove rand * rename, clean up and make axis spec work * clean up and test new conversion pipeline * undo feature deletion, don't reintroduce Rect2f * be explicit about Volume Interval types * minor docstring cleanup * try to clarify new conversion docstrings * remove convert_arguments_typed in favor of types_for_plot_arguments * fix remaining bugs for conversion simplification * fix ticks not updating * fix specapi * fix qqnorm * clean up types_for_plot_arguments * fix tuple conversion * try to fix compile time regression * try to fix compile time regression * clean up and introduce expand_dimensions * fix #3655 and clean up convert_arguments + add tests * fix #3509 and add tests for * clean up observables and more docs * final rename * fix docs * cleanup * small clean up * small doc improvements * improve docs * fix docs * try relative link * try without .md * take out link * try fix --------- Co-authored-by: ffreyer <frederic481994@hotmail.de> * fix comment * Add wrap recipe tutorial (#3816) * [Docs] add wrap/redirect recipe tutorial * fix sentence * Update docs/tutorials/wrap-existing-recipe.md Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com> * update * fix doc build * add changelog * fix preview --------- Co-authored-by: Moelf <proton@jling.dev> Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com> * only forward attributes usable by recipe * make sharing of attributes explicit * ci * fix RPRMakie material * small fixes * fix RPRMakie * fix series with BezierPath * fix series conversions --------- Co-authored-by: Frederic Freyer <frederic481994@hotmail.de> Co-authored-by: Julius Krumbiegel <22495855+jkrumbiegel@users.noreply.github.com> Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com> Co-authored-by: Moelf <proton@jling.dev>

SimonDanisch added 3 commits September 29, 2021 17:39

time axis mvp

7ab48a9

use Unitful + better default unit selection

a46baa2

fix some more edge cases, add more examples

d93cdde

proper unitful integration

20734db

ffreyer reviewed Oct 4, 2021

View reviewed changes

src/makielayout/layoutables/time_axis.jl Outdated Show resolved Hide resolved

SimonDanisch added 6 commits October 5, 2021 13:56

clean up implementation + make arbitrary units work

181489a

properly integrate time-axis

c965e16

add wip docs

c689b46

add deps

13e30db

move axis convert to Axis

089dfb9

fix tests

4c409bf

SimonDanisch added 3 commits October 8, 2021 13:25

simplify best unit

d5e1e07

simplify, add categorical, add dates

96bf937

fix tests

9bc1ae2

SimonDanisch added 12 commits October 13, 2021 18:35

make time/unit conversion work with convert_arguments

14e8274

correctly convert

4697421

figure out axis type smarter, fix pre_convert

744e13e

formatting

0aed3aa

more carefully apply converts

9ccb141

merge in master

d300c79

add proper error for empty limits

86e95df

merge master

28b6d77

Merge branch 'sd/time-axis' of https://github.com/JuliaPlots/Makie.jl …

e15eee1

…into sd/time-axis

add limits

62176cf

fix last tests

b6bdc7f

improve units

6a5fd8d

SimonDanisch added 5 commits January 10, 2022 22:09

merge master

9566047

add Dates

0877ca7

add Unitful

26dc721

fix tests

f34a4db

fix tests

9f15d55

rapus95 mentioned this pull request Mar 8, 2022

Introduce AxisSpace type to generalize and solve multiple problems #1731

Closed

SimonDanisch added 2 commits March 18, 2022 12:28

merge master

03fc805

Merge branch 'master' into sd/time-axis

7d5ac50

MakieOrg deleted a comment from MakieBot Jul 12, 2022

SimonDanisch added 2 commits November 14, 2022 13:35

merge master

005527e

merge master

7f4a32e

Merge branch 'master' into sd/time-axis

4cad9e1

jariji mentioned this pull request Mar 30, 2023

Support for Unitful.jl values #1191

Closed

SimonDanisch mentioned this pull request Apr 27, 2023

Support for axis unit change #2154

Closed

SimonDanisch mentioned this pull request Aug 23, 2023

How to plot a heatmap with categorical variables #3169

Closed

SimonDanisch added a commit that referenced this pull request Sep 11, 2023

take over most of the work from #1347

1ee5d31

SimonDanisch mentioned this pull request Sep 11, 2023

Unit support for Axes & Recipes, a.k.a axis converts #3226

Merged

SimonDanisch closed this Sep 11, 2023

t-bltg added the units aka dim converts label May 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement time axis #1347

Implement time axis #1347

SimonDanisch commented Sep 29, 2021 •

edited

Loading

ffreyer commented Oct 1, 2021

SimonDanisch commented Oct 4, 2021

SimonDanisch commented Oct 7, 2021 •

edited

Loading

visr commented Oct 11, 2021

laborg commented Jan 14, 2022

SimonDanisch commented Jan 14, 2022

SimonDanisch commented Jan 14, 2022 •

edited

Loading

SimonDanisch commented Jan 14, 2022

rapus95 commented Jan 18, 2022 •

edited

Loading

jeremiedb commented Jul 12, 2022

uniment commented Sep 23, 2022

MakieBot commented Nov 14, 2022 •

edited

Loading

SimonDanisch commented Sep 11, 2023

Implement time axis #1347

Implement time axis #1347

Conversation

SimonDanisch commented Sep 29, 2021 • edited Loading

ffreyer commented Oct 1, 2021

SimonDanisch commented Oct 4, 2021

SimonDanisch commented Oct 7, 2021 • edited Loading

visr commented Oct 11, 2021

laborg commented Jan 14, 2022

SimonDanisch commented Jan 14, 2022

SimonDanisch commented Jan 14, 2022 • edited Loading

SimonDanisch commented Jan 14, 2022

rapus95 commented Jan 18, 2022 • edited Loading

jeremiedb commented Jul 12, 2022

uniment commented Sep 23, 2022

MakieBot commented Nov 14, 2022 • edited Loading

Compile Times benchmark

SimonDanisch commented Sep 11, 2023

SimonDanisch commented Sep 29, 2021 •

edited

Loading

SimonDanisch commented Oct 7, 2021 •

edited

Loading

SimonDanisch commented Jan 14, 2022 •

edited

Loading

rapus95 commented Jan 18, 2022 •

edited

Loading

MakieBot commented Nov 14, 2022 •

edited

Loading