Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect other cameras when switching to PixelCamera #1504

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Dec 8, 2021

If you do something like this

fig = Figure()
scene = LScene(fig[1, 1], show_axis = false)
campixel!(scene.scene)
scatter!(scene, 400rand(10), 400rand(10))
fig

and then click (and drag) the plot area everything will disappear. That happens because campixel! does not disconnect the previous camera, in this case Camera3D. The pr fixes that.

@ffreyer
Copy link
Collaborator Author

ffreyer commented Dec 10, 2021

Failing tests are from missing/old refimages. We can merge this

@SimonDanisch SimonDanisch merged commit e437828 into master Dec 10, 2021
@SimonDanisch SimonDanisch deleted the ff/fixes branch December 10, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants