make it possible to have one color per glyph #1582
Conversation
jkrumbiegel
left a comment
jkrumbiegel
left a comment
There was a problem hiding this comment.
this is one of these places in the code base where it's difficult to know what type color etc could have, and therefore how the code will execute. also, I guess we recompile this expensive looking function for a color given as a Symbol vs. as an RGBf etc. I would like clearer logic, or does that tie into the attribute refactor idea?
src/layouting/layouting.jl
Outdated
| [color for x in charinfos], | ||
| [strokecolor for x in charinfos], | ||
| [strokewidth for x in charinfos], | ||
| per_char_info(rotation, charinfos), |
There was a problem hiding this comment.
hm neither what I had before nor this seems ideal. there is already a function called attribute_per_char at the top, this is currently used for font and textsize, but similar logic could apply to color. anyway, it feels weird to do one expansion before the glyph_collection function and one here.
There was a problem hiding this comment.
Ah, I somehow didnt find that function... So I guess I should just use that?
There was a problem hiding this comment.
Ok, this uses attribute_per_char now!
To separate the concerns a bit, I would leave this for the attribute refactor PR, as long as this PR doesn't introduce any regressions |
No description provided.