Add polar plot and scatter recipes #1706
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # 521
I added two recipes for creating polar plots and scatter polar plots, following the plan posted in issue #521 by @asinghvi17. I understand (from other issues) that there is some inconsistency with how Attributes are used, so I wasn't sure what to do there and mostly followed other recipes. I also would like to remove the xy axes spines and decorations, but I have seen elsewhere that this is under consideration since recipes are apparently older than the Axis framework. I wasn't sure how to handle the docs, and I put the
lines!plot andscatter!plot examples in the same .md file. The plots I include in the docs are attached to this PR.As far as setting r-ticks and theta-ticks, does my solution look reasonable? I thought this in particular would need to be reviewed.
(This is my first PR (ever!), so please guide me if there's something I'm missing)
Type of change
Checklist
Images
polar(r, theta)polarscatter(r, theta)