Add empty!(fig) and cleanup empty!(scene)
#1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Triggering |
SimonDanisch
reviewed
May 2, 2022
SimonDanisch
approved these changes
May 3, 2022
ffreyer
commented
May 4, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an error in
empty!(scene), makes it delete all plots in all child scenes and stops it from disconnecting the screen.It also adds
empty!(fig)clearing all attached scenes and the layout. (Following jkrumbiegel/GridLayoutBase.jl#2 here, thoughdelete!seems unnecessary to me?)Related: #1595
Type of change
Checklist