streamline convert_for_attribute #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrumbiegel
approved these changes
May 12, 2022
|
Should we release a new patch version with this? |
|
On it: #1924 |
kunzaatko
pushed a commit
to kunzaatko/Makie.jl
that referenced
this pull request
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows us to upgrade Makie in AlgebraOfGraphics without this piracy.
As the general fallbacks for
convert_for_attributedo the correct thing, this removes a few method to avoid ambiguities. In particular,convert_for_attribute(t::Type{Makie.FreeTypeAbstraction.FTFont}, x::Makie.FreeTypeAbstraction.FTFont)now does the correct thing instead of a method error.Type of change