Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
ba2318a
start implementation
jkrumbiegel Apr 17, 2022
ad8900c
First implementation of polar axis
asinghvi17 Jun 1, 2022
9f662fb
Try to make the polar axis "plottable-to"
asinghvi17 Jun 1, 2022
828c9a4
Revert MakieLayout.jl to master state
asinghvi17 Jun 1, 2022
be9302b
Correct documentation of `adjustcam!`
asinghvi17 Jun 1, 2022
8a1d0a6
Implement angular ticks
asinghvi17 Jun 1, 2022
9f2c0a3
Inherit a bit more
asinghvi17 Jun 2, 2022
8c2dc4b
Implement radial ticks
asinghvi17 Jun 2, 2022
3d0f20c
Fix translation for GLMakie
asinghvi17 Jun 4, 2022
eff6180
In Camera2D's ratio check, use only Float32 to compare
asinghvi17 Jun 4, 2022
603f706
Fix bad bbox method, add comments
asinghvi17 Jun 4, 2022
25dca9a
Remove debug statements
asinghvi17 Jun 4, 2022
4fd1d5d
Update for MakieLayout module removal
asinghvi17 Jun 8, 2022
5539a5a
Update the lines when the camera changes.
asinghvi17 Jun 8, 2022
0e4292d
Lift on camera also
asinghvi17 Jun 8, 2022
1d133a1
Add protrusion calculation for theta ticks
asinghvi17 Jun 27, 2022
0ea9644
Allow plot!(po::PolarAxis, ...)
asinghvi17 Jun 27, 2022
e9ba2e4
Manual protrusion calc by checking text bboxes individually.
asinghvi17 Jun 28, 2022
227b0b5
Implement a foundation for hacked theta-lims
asinghvi17 Jun 28, 2022
e662ee6
Fix update_cam!(::Scene)
asinghvi17 Jun 28, 2022
aa0bb82
Quick fix for overlooked item
asinghvi17 Jun 30, 2022
08d7a91
Implement `text_bbox(plot::Text)`
asinghvi17 Jun 30, 2022
8fb816f
Implement inherit for nested theme attributes
asinghvi17 Jun 30, 2022
44eb5ba
Implement title for PolarAxis
asinghvi17 Jun 30, 2022
e2a3582
Switch default theme to inheriting from Axis
asinghvi17 Jun 30, 2022
3dba936
Separate r and theta minor grids in theme
asinghvi17 Jun 30, 2022
bfc2c1d
Update NEWS
asinghvi17 Jun 30, 2022
f2c90c8
General cleanup
asinghvi17 Jun 30, 2022
60ee94a
Adjust ticks, grid and camera on scene area / limit change
asinghvi17 Jun 30, 2022
9432e1f
Change r-tick angle to avoid overlap
asinghvi17 Jun 30, 2022
ae09053
Implement "nonlinear clip" without transparency
asinghvi17 Jun 30, 2022
afbde6e
Address comments from code review
asinghvi17 Jul 1, 2022
061dabd
Merge branch 'master' into jk/polar-axis
Moelf Jul 13, 2022
f6b69b2
Merge branch 'master' into jk/polar-axis
SimonDanisch Jan 14, 2023
2542326
Merge branch 'master' into jk/polar-axis
SimonDanisch May 17, 2023
190cb33
fix errors
ffreyer May 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## master

- Added a new Axis type, `PolarAxis`, which is an axis with a polar projection. Input is in `(r, theta)` coordinates and is transformed to `(x, y)` coordinates using the standard polar-to-cartesian transformation. Generally, its attributes are very similar to the usual `Axis` attributes, but `x` is replaced by `r` and `y` by `θ`. It also inherits from the theme of `Axis` in this manner, so should work seamlessly with Makie themes. [#2014](https://www.github.com/JuliaPlots/Makie.jl/pull/2014)
- `inherit` now has a new signature `inherit(scene, attrs::NTuple{N, Symbol}, default_value)`, allowing recipe authors to access nested attributes when trying to inherit from the parent Scene. For example, one could inherit from `scene.Axis.yticks` by `inherit(scene, (:Axis, :yticks), $default_value)`. [#2014](https://www.github.com/JuliaPlots/Makie.jl/pull/2014)
- Fixed `update_cam!(scene::Scene)` by changing the internal call to `limits` to a call to `boundingbox`. [#2014](https://www.github.com/JuliaPlots/Makie.jl/pull/2014)

## v0.19.5

- Add `loop` option for GIF outputs when recording videos with `record` [#2891](https://github.com/MakieOrg/Makie.jl/pull/2891).
Expand Down Expand Up @@ -144,7 +148,7 @@ role as `datalimits` in `violin` [#2137](https://github.com/MakieOrg/Makie.jl/pu

## v0.17.7

- Improved `Menu` performance, now it should me much harder to reach the boundary of 255 scenes in GLMakie. `Menu` also takes a `default` keyword argument now and can be scrolled if there is too little space available.
- Improved `Menu` performance, now it should be much harder to reach the boundary of 255 scenes in GLMakie. `Menu` also takes a `default` keyword argument now and can be scrolled if there is too little space available.

## v0.17.6

Expand Down
2 changes: 1 addition & 1 deletion src/camera/camera2d.jl
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function update_cam!(scene::Scene, cam::Camera2D, area3d::Rect)
px_wh = normalize(widths(pa))
wh = normalize(widths(area))
ratio = px_wh ./ wh
if ratio ≈ Vec(1.0, 1.0)
if ratio ≈ Vec(1f0, 1f0)
cam.area[] = area
else
# we only want to make the area bigger, to at least show what was selected
Expand Down
4 changes: 3 additions & 1 deletion src/makielayout/MakieLayout.jl
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ include("lineaxis.jl")
include("interactions.jl")
include("blocks/axis.jl")
include("blocks/axis3d.jl")
include("blocks/polaraxis.jl")
include("blocks/colorbar.jl")
include("blocks/label.jl")
include("blocks/slider.jl")
Expand All @@ -36,6 +37,7 @@ include("blocks/textbox.jl")

export Axis
export Axis3
export PolarAxis
export Slider
export SliderGrid
export IntervalSlider
Expand All @@ -60,7 +62,7 @@ export labelslider!, labelslidergrid!
export addmouseevents!
export interactions, register_interaction!, deregister_interaction!, activate_interaction!, deactivate_interaction!
export MouseEventTypes, MouseEvent, ScrollEvent, KeysEvent
# export hlines!, vlines!, abline!, hspan!, vspan!
export hlines!, vlines!, abline!, hspan!, vspan!
export Cycle
export Cycled

Expand Down
Loading