Skip to content

Conversation

@jkrumbiegel
Copy link
Member

Description

Fixes MakieOrg/AlgebraOfGraphics.jl#299, #1535, #1215

As @ffreyer noted, the limits of a 2D plot can actually be inferred from the projection view matrix. Therefore, I've reimplemented all recipes that were previously using the special function form with an Axis argument. This also allows using these functions in AlgebraOfGraphics such as visual(HLines).

I've also deprecated abline! and called the recipe ablines! just because it can actually plot multiple lines at once and all the other lines functions are named the same way.

Type of change

Delete options that do not apply:

  • New feature (non-breaking change which adds functionality)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation

@MakieBot
Copy link
Collaborator

MakieBot commented Jun 6, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt.

using time

master:  10.78 < 11.11 > 11.20, 0.14+-
pr:      11.01 < 11.14 > 11.44, 0.18+-
speedup: 0.97 < 0.99 > 1.01, 0.01+-
median:  +0.29% => invariant

This PR does not change the using time.

ttfp time

master   30.63 < 31.28 > 31.57, 0.34+-
pr       31.04 < 31.54 > 31.99, 0.37+-
speedup: 0.96 < 0.99 > 1.01, 0.02+-
median:  +0.84% => invariant

This PR does not change the ttfp time.

@jkrumbiegel jkrumbiegel merged commit 07142b0 into master Jun 6, 2022
@jkrumbiegel jkrumbiegel deleted the jk/hvlines-hvspan-ablines-recipes branch June 6, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hlines! and vlines!

4 participants