Reimplement hvlines, hvspan and ablines as recipes #2023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes MakieOrg/AlgebraOfGraphics.jl#299, #1535, #1215
As @ffreyer noted, the limits of a 2D plot can actually be inferred from the projection view matrix. Therefore, I've reimplemented all recipes that were previously using the special function form with an
Axisargument. This also allows using these functions in AlgebraOfGraphics such asvisual(HLines).I've also deprecated
abline!and called the recipeablines!just because it can actually plot multiple lines at once and all the other lines functions are named the same way.Type of change
Delete options that do not apply:
Checklist