Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirrored Axis ticks #2105

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Mirrored Axis ticks #2105

merged 4 commits into from
Jul 5, 2022

Conversation

jkrumbiegel
Copy link
Member

@jkrumbiegel jkrumbiegel commented Jul 2, 2022

Description

Fixes #2091

Add a description of your PR here.

Type of change

Delete options that do not apply:

  • New feature (non-breaking change which adds functionality)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation

@MakieBot
Copy link
Collaborator

MakieBot commented Jul 2, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 13.50s (13.38, 13.61) 0.08+- 23.62s (23.43, 23.76) 0.12+- 19.70s (19.56, 19.83) 0.09+- 20.16ms (20.03, 20.32) 0.10+- 81.00ms (79.90, 82.54) 1.12+-
master 13.51s (13.41, 13.65) 0.09+- 23.41s (23.25, 23.76) 0.19+- 19.63s (19.51, 19.91) 0.16+- 19.82ms (19.69, 20.09) 0.14+- 78.65ms (77.54, 79.79) 0.83+-
evaluation -0.05%, -0.01s invariant (-0.08d, 0.88p, 0.08std) +0.89%, 0.21s slower X (1.33d, 0.03p, 0.15std) +0.35%, 0.07s invariant (0.52d, 0.35p, 0.13std) +1.67%, 0.34ms slower X (2.73d, 0.00p, 0.12std) +2.91%, 2.35ms slower X (2.40d, 0.00p, 0.97std)
CairoMakie 11.34s (11.30, 11.38) 0.03+- 23.97s (23.93, 24.07) 0.05+- 3.49s (3.48, 3.50) 0.01+- 18.23ms (18.12, 18.38) 0.08+- 25.26ms (25.20, 25.42) 0.07+-
master 11.32s (11.30, 11.37) 0.02+- 23.72s (23.70, 23.77) 0.02+- 3.53s (3.50, 3.58) 0.03+- 17.62ms (17.56, 17.74) 0.06+- 25.26ms (25.20, 25.31) 0.04+-
evaluation +0.14%, 0.02s invariant (0.63d, 0.26p, 0.03std) +1.04%, 0.25s slower X (6.38d, 0.00p, 0.04std) -1.05%, -0.04s faster ✓ (-1.99d, 0.01p, 0.02std) +3.30%, 0.6ms slower X (8.19d, 0.00p, 0.07std) -0.02%, -0.0ms invariant (-0.08d, 0.88p, 0.05std)
WGLMakie 17.58s (17.37, 17.78) 0.16+- 40.76s (40.27, 41.40) 0.35+- 67.55s (66.34, 68.29) 0.71+- 32.77ms (31.98, 33.21) 0.39+- 1.87s (1.86, 1.89) 0.01+-
master 17.68s (17.45, 18.12) 0.23+- 40.68s (40.58, 40.89) 0.11+- 67.66s (66.76, 68.03) 0.46+- 31.79ms (31.03, 32.49) 0.54+- 1.89s (1.86, 1.92) 0.03+-
evaluation -0.55%, -0.1s invariant (-0.48d, 0.38p, 0.20std) +0.20%, 0.08s invariant (0.31d, 0.58p, 0.23std) -0.17%, -0.11s invariant (-0.19d, 0.73p, 0.58std) +3.00%, 0.98ms slower X (2.09d, 0.00p, 0.47std) -0.99%, -0.02s invariant (-0.94d, 0.11p, 0.02std)

@jkrumbiegel
Copy link
Member Author

@SimonDanisch seems to be slightly slower, but I guess that's expected because it's doing more? I'll merge if you approve

@jkrumbiegel jkrumbiegel merged commit e04443a into master Jul 5, 2022
@jkrumbiegel jkrumbiegel deleted the jk/mirrored-ticks branch July 5, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to show ticks on both sides of an axis
4 participants