Skip to content

Conversation

@palday
Copy link
Contributor

@palday palday commented Nov 20, 2022

Description

Very minor change addressing a deprecation warning from Distributions.jl:

┌ Warning: `quantile(d::UnivariateDistribution, X::AbstractArray)` is deprecated, use `quantile.(d, X)` instead.
│   caller = fit_qqplot(x::Normal{Float64}, y::Vector{Float64}; qqline::Symbol) at distributions.jl:102
└ @ Makie ~/.julia/packages/Makie/xhxRd/src/stats/distributions.jl:102

The broadcasted method is perhaps slightly less efficient than the Array method, but since there are only two quantiles being computed, it doesn't really matter and will have full backward compatibility.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@jkrumbiegel jkrumbiegel merged commit 868a19c into MakieOrg:master Nov 20, 2022
@palday palday deleted the pa/quantile branch November 28, 2022 18:37
t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants