Skip to content

Conversation

@SimonDanisch
Copy link
Member

Rebased version of #3845

@MakieBot
Copy link
Collaborator

MakieBot commented May 24, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.34s (4.29, 4.36) 0.03+- 105.91ms (104.54, 108.09) 1.31+- 483.39ms (480.40, 488.66) 3.43+- 7.82ms (7.74, 7.90) 0.06+- 25.71ms (25.57, 25.93) 0.13+-
master 4.35s (4.31, 4.40) 0.04+- 105.55ms (104.84, 106.74) 0.81+- 483.92ms (479.95, 487.04) 2.73+- 7.88ms (7.79, 8.01) 0.09+- 25.66ms (25.56, 25.79) 0.07+-
evaluation 1.00x invariant, -0.01s (-0.28d, 0.61p, 0.03std) 1.00x invariant, 0.36ms (0.33d, 0.55p, 1.06std) 1.00x invariant, -0.53ms (-0.17d, 0.75p, 3.08std) 1.01x invariant, -0.05ms (-0.68d, 0.23p, 0.08std) 1.00x invariant, 0.05ms (0.47d, 0.40p, 0.10std)
CairoMakie 3.73s (3.54, 3.84) 0.12+- 103.57ms (103.05, 104.23) 0.44+- 126.74ms (126.28, 126.94) 0.22+- 7.53ms (7.50, 7.57) 0.03+- 983.24μs (977.17, 991.68) 5.22+-
master 3.58s (3.56, 3.60) 0.02+- 103.41ms (102.98, 104.49) 0.51+- 127.02ms (126.29, 128.87) 0.87+- 7.50ms (7.43, 7.61) 0.06+- 971.18μs (962.74, 981.04) 6.96+-
evaluation 0.96x slower X, 0.15s (1.66d, 0.02p, 0.07std) 1.00x invariant, 0.16ms (0.33d, 0.55p, 0.47std) 1.00x invariant, -0.27ms (-0.43d, 0.44p, 0.54std) 1.00x invariant, 0.03ms (0.71d, 0.22p, 0.04std) 0.99x slower X, 12.06μs (1.96d, 0.00p, 6.09std)
WGLMakie 4.42s (4.38, 4.46) 0.03+- 105.42ms (104.75, 106.77) 0.75+- 8.83s (8.63, 9.06) 0.18+- 9.84ms (9.70, 9.90) 0.07+- 70.65ms (70.11, 71.07) 0.32+-
master 4.46s (4.41, 4.50) 0.03+- 108.14ms (105.67, 115.63) 3.47+- 9.06s (8.99, 9.21) 0.08+- 10.20ms (9.83, 11.61) 0.63+- 70.56ms (69.70, 71.22) 0.54+-
evaluation 1.01x faster ✓, -0.04s (-1.35d, 0.03p, 0.03std) 1.03x invariant, -2.72ms (-1.09d, 0.08p, 2.11std) 1.03x faster ✓, -0.23s (-1.59d, 0.02p, 0.13std) 1.04x invariant, -0.36ms (-0.80d, 0.18p, 0.35std) 1.00x invariant, 0.09ms (0.20d, 0.71p, 0.43std)

@barucden
Copy link
Contributor

Is there anything left to be done here?

@SimonDanisch SimonDanisch requested a review from jkrumbiegel May 27, 2024 10:36
@jkrumbiegel jkrumbiegel merged commit cadb1fe into master May 27, 2024
@jkrumbiegel jkrumbiegel deleted the restrict-pdf-version branch May 27, 2024 11:40
@SimonDanisch
Copy link
Member Author

Thank you @barucden!

@barucden
Copy link
Contributor

Amazing! Thank you. Looking forward to the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants