Skip to content

Conversation

@SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Sep 3, 2024

Fixes https://discourse.julialang.org/t/glmakie-issue-with-select-rectangle/119008
Although I don't fully understand why xy isnt a tuple in that error.

Fix ambiguity
@MakieBot
Copy link
Collaborator

MakieBot commented Sep 3, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.35s (4.32, 4.39) 0.02+- 107.24ms (104.60, 116.65) 4.30+- 546.54ms (539.18, 566.94) 9.68+- 8.95ms (8.89, 9.01) 0.04+- 25.86ms (25.75, 25.99) 0.09+-
master 4.33s (4.31, 4.36) 0.02+- 105.82ms (104.11, 110.41) 2.19+- 544.20ms (535.33, 565.39) 9.74+- 8.94ms (8.91, 8.96) 0.02+- 25.93ms (25.66, 26.03) 0.14+-
evaluation 1.00x invariant, 0.02s (0.85d, 0.14p, 0.02std) 0.99x invariant, 1.42ms (0.41d, 0.46p, 3.25std) 1.00x invariant, 2.35ms (0.24d, 0.66p, 9.71std) 1.00x invariant, 0.01ms (0.43d, 0.45p, 0.03std) 1.00x invariant, -0.07ms (-0.59d, 0.30p, 0.12std)
CairoMakie 3.88s (3.87, 3.90) 0.01+- 106.72ms (104.39, 111.09) 2.14+- 161.97ms (158.67, 163.92) 1.76+- 9.49ms (9.05, 9.63) 0.20+- 1.18ms (1.15, 1.23) 0.03+-
master 3.89s (3.86, 3.93) 0.03+- 107.67ms (104.74, 111.42) 2.61+- 161.48ms (159.12, 162.89) 1.38+- 9.66ms (9.45, 9.75) 0.10+- 1.19ms (1.18, 1.22) 0.01+-
evaluation 1.00x invariant, -0.0s (-0.17d, 0.76p, 0.02std) 1.01x invariant, -0.95ms (-0.40d, 0.47p, 2.38std) 1.00x invariant, 0.49ms (0.31d, 0.58p, 1.57std) 1.02x invariant, -0.17ms (-1.05d, 0.08p, 0.15std) 1.01x invariant, -0.01ms (-0.62d, 0.28p, 0.02std)
WGLMakie 4.63s (4.54, 4.72) 0.06+- 109.88ms (106.70, 114.37) 2.65+- 9.36s (9.10, 9.61) 0.22+- 11.37ms (11.18, 11.54) 0.12+- 116.68ms (113.46, 121.08) 2.38+-
master 4.66s (4.62, 4.70) 0.03+- 109.99ms (106.85, 113.85) 2.29+- 9.50s (9.39, 9.73) 0.11+- 11.79ms (11.26, 14.02) 0.99+- 118.67ms (114.71, 124.99) 3.54+-
evaluation 1.01x invariant, -0.02s (-0.50d, 0.38p, 0.05std) 1.00x invariant, -0.12ms (-0.05d, 0.93p, 2.47std) 1.01x invariant, -0.14s (-0.77d, 0.18p, 0.17std) 1.04x invariant, -0.42ms (-0.60d, 0.30p, 0.56std) 1.02x invariant, -1.99ms (-0.66d, 0.24p, 2.96std)

@SimonDanisch SimonDanisch changed the title Update camera2d.jl Fix absrect for select_rectangle Sep 4, 2024
@SimonDanisch
Copy link
Member Author

Ok, the mystery got solved, this was already fixed on master :D
I think, I still want to merge the updated version, since i like the map version more.

@SimonDanisch SimonDanisch marked this pull request as ready for review September 4, 2024 09:55
@SimonDanisch SimonDanisch merged commit b7645d0 into master Sep 4, 2024
@SimonDanisch SimonDanisch deleted the sd/fix-select-rect branch September 4, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants