Skip to content

Fix absrect for select_rectangle #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Fix absrect for select_rectangle #4312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16155aa
Update camera2d.jl
SimonDanisch Sep 3, 2024
57e2e1e
clean up implementation
SimonDanisch Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [Unreleased]

- Fix for absrect [#4312](https://github.com/MakieOrg/Makie.jl/pull/4312).
- Fix attribute updates for SpecApi and SpecPlots (e.g. ecdfplot) [#4265](https://github.com/MakieOrg/Makie.jl/pull/4265).
- Bring back `poly` convert arguments for matrix with points as row [#4266](https://github.com/MakieOrg/Makie.jl/pull/4258).
- Fix gl_ClipDistance related segfault on WSL with GLMakie [#4270](https://github.com/MakieOrg/Makie.jl/pull/4270)
Expand Down
9 changes: 4 additions & 5 deletions src/camera/camera2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,13 +195,12 @@ function camspace(scene::SceneLike, cam::Camera2D, point)
return Vec(point) .+ Vec(minimum(cam.area[]))
end

function absrect(rect)
function absrect(rect::Rect)
xy, wh = minimum(rect), widths(rect)
xy = ntuple(Val(2)) do i
wh[i] < 0 ? xy[i] + wh[i] : xy[i]
xy = map(xy, wh) do xy, wh
wh < 0 ? xy + wh : xy
end

return Rect2(Vec2(xy), abs.(wh))
return Rect2(xy, abs.(wh))
end


Expand Down