Fix surface update & add test #4529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://discourse.julialang.org/t/makie-observable-bug/121724 - surface not correctly resizing to updated args.
In GLMakie
instanceswas lfiting off of a Texture, which doesn't actually propagate updates. Now it usesplot[3], i.e. the converted z matrix Observable.In WGLMakie a tessellated rect is generated for the surface plot. In a second step faces connected to nan-points are filtered out. This desynchronizes on update, causing an error. Fixed by excluding faces referring to out-of-bounds points.
The added refimg tests reducing and increasing size for range, vector and matrix x/y.
Type of change
Checklist