-
-
Notifications
You must be signed in to change notification settings - Fork 362
Date ticks overhaul #5159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date ticks overhaul #5159
Conversation
Benchmark ResultsSHA: b0f16679bf786df8850beaae4864a3321e6ee89e Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking. |
|
One question for review is whether |
|
Ok I've decided to remove the date-specific functions after all and simply use dispatches on I've also left in the |
Co-authored-by: Anshul Singhvi <asinghvi17@simons-rock.edu>
|
This is amazing, thank you so much! |
This PR changes the way that ticks for datetime axes are located and formatted by default. The new tick formatting reduces the amount of redundant information by printing time on a separate line from date (if time is different from 0). This way, the date only has to be shown whenever it changes from tick to tick. Similarly, only the time component of the tick step size is usually shown, unless there's a step in the parent component. For example, seconds would be shown
:58,:59but then as the minute changes, the full time is shown like03:17:00and then further:01,:02, etc.Fixes #4404, fixes #3972, fixes #3959
This PR
Master
This PR also adds a separate dispatch route for datetime ticks which fixes the bug that the ticks or the tick format could not be changed manually and were always hardcoded to the automatic tick finding algorithm.