-
-
Notifications
You must be signed in to change notification settings - Fork 362
Update 3D contours #5213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update 3D contours #5213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Benchmark ResultsSHA: 2db05a7fc471ccffddac2f9dbae0bb4143f66619 Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking. |
…into ff/3d-contour
SimonDanisch
approved these changes
Aug 5, 2025
Member
|
Is this ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mildly related to #5194
This pr updates
contour(..., ::Array{Float, 3})to rely on the compute graph and introduced some changes to the colormapping:colorrangenow defaults to the extrema oflevelsrather than the extrema of the given datacolormapused to always generate colors for the full value rangeminimum(volumedata) .. maximum(volumedata), but reportcolorrangeas its limits to volume. This made any 3D contour with a non default colorrange incorrect. Now the colormap generates for slightly padded colorrange (to include a transparent min and max color) which gets passed down correctly.isorangeis now a setable attribute againisorangeno longer assumes uniform levels. Instead it's generated based on the minimum distance between levelsBy example:
1, 2 show off different colorrange defaultsTODO:
Type of change
... maybe breaking due to change in colorrange defaulting?Checklist