Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some songs won't download #170

Open
4 tasks done
Deemitry88 opened this issue Jul 5, 2024 · 19 comments
Open
4 tasks done

Some songs won't download #170

Deemitry88 opened this issue Jul 5, 2024 · 19 comments
Labels
bug Something isn't working can't reproduce This bug isn't reproducible

Comments

@Deemitry88
Copy link

Checklist

  • I am able to reproduce the bug with the latest debug version.
  • I've checked that there is no open or closed issue about this bug.
  • This issue contains only one bug.
  • The title of this issue accurately describes the bug.

Steps to reproduce the bug

  1. Go to a playlist
  2. Sometimes some songs wont download

Expected behavior

The songs should download...

Actual behavior

...but they don't

Screenshots/Screen recordings

Screenshot_20240706_011654_InnerTune

I just get this error that says "The download failed"

Logs

I don't have access to a pc right now

InnerTune version

0.5.7

Android version

Android 12

Additional information

No response

@Deemitry88 Deemitry88 added the bug Something isn't working label Jul 5, 2024
@Malopieds
Copy link
Owner

Sometimes some songs wont download

Sometimes as in some will never download or some will have to be downloaded again?
Either way I can download both of them

@Deemitry88
Copy link
Author

They will never download, if I try to download them again they will just try to download indefinitely until I stop the download

@Malopieds
Copy link
Owner

They will never download, if I try to download them again they will just try to download indefinitely until I stop the download

Weird, even when only downloading one? I will need some log for this

@Malopieds Malopieds added the can't reproduce This bug isn't reproducible label Jul 6, 2024
@Deemitry88
Copy link
Author

Deemitry88 commented Jul 6, 2024

How do I get thoses logs ? Even If I do logcat | grep com.malopieds.innertune I won't get any of innertune's logs but only android's one referencing innertune

Malopieds added a commit that referenced this issue Jul 6, 2024
@Malopieds
Copy link
Owner

Try the latest debug version, there should be the error in the notification (but the text might be too long) and the error on the logs under the tag Download failed, send them here !

Malopieds added a commit that referenced this issue Jul 6, 2024
@Malopieds
Copy link
Owner

Well I don't know why it doesn't want to build, it works well for me with the same command... You can clone the repo and try it yourself if you know how to do it. Ask me if you have any question

@Deemitry88
Copy link
Author

I got this error while trying to build
logErrors.txt

@Malopieds
Copy link
Owner

To build the debug version use this command:
./gradlew assembleDebug lintFossDebug testFossDebugUnitTest --stacktrace -DskipFormatKtlint
the output file will be in app/build/outputs/apk/foss/debug/app-foss-debug.apk

@Deemitry88
Copy link
Author

I can figure out how to make it work

@Malopieds
Copy link
Owner

I can figure out how to make it work

To make it build or to be able to download it?

@malisipi malisipi mentioned this issue Jul 11, 2024
4 tasks
@malisipi
Copy link

I think the reason is the rate limit, caching and the following issue. #178 (comment)

@ElhamAryanpur
Copy link

Yeah same issue happened to me, it straight up doesn't even play some songs in the playlist. I agree it might be ratelimit

@Deemitry88
Copy link
Author

Yeah, it is definitely rate limit, is there any way to wipe the cache so we can download those song again ?

@Irobrine
Copy link

Seems to be happening to me as well. The longer the song, the slower the download becomes until it basically doesn't download at all.
Songs below 8 minutes: Max speed
Songs between 8 to 15 minutes: ~2MB/s
Songs above 15: ~20KB/s
(These are estimates)

@Deemitry88
Copy link
Author

@Malopieds ?

@Malopieds
Copy link
Owner

I don't know what I can possibly do for a rate limit as of now.

@ElhamAryanpur
Copy link

I have been trying to play the same songs after weeks, still same issue. possibly not a rate limit in this case? Because even with VPN, without VPN, with or without large time past since last download, the result is the same, unplayable for some songs.

@Deemitry88
Copy link
Author

I don't know what I can possibly do for a rate limit as of now.

As I said you could just add the ability to wipe the cache so we can download the songs again

@Malopieds
Copy link
Owner

As I said you could just add the ability to wipe the cache so we can download the songs again

A rate limit and the cache have nothing to do in common. It may be related to the cache but even re-syncing the song (there is a button for that now) doesn't seems to do anything. It looks like a null pointer but I don't know from where.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can't reproduce This bug isn't reproducible
Projects
None yet
Development

No branches or pull requests

5 participants