fix: simplify COPR workflow and fix make install#764
Open
dacrab wants to merge 1 commit into
Open
Conversation
- Remove chroot selection logic from COPR workflow; copr-cli build without -r automatically targets all project-enabled chroots - Add missing build dependencies (pipewire, wayland, clang, etc.) - Remove workflow_dispatch chroots input (manage chroots via COPR project settings) - Fix Makefile install: use install -Dm755 with DESTDIR/PREFIX support instead of sudo cp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copr-cli buildwithout-rflags automatically builds for all chroots enabled in the COPR project, so chroot management is done via project settings (orcopr-cli modify) rather than hardcoded in CI.sudo cp -fwithinstall -Dm755and supportDESTDIR/PREFIXvariables for proper packaging integration.Changes
.github/workflows/copr-build.ymlworkflow_dispatchchroots input, add build deps, simplify build stepMakefileinstall -Dm755withDESTDIR/PREFIXsupportNotes
The
COPR_CONFIGsecret still needs to be configured in the repository for the workflow to submit builds. Without it, the workflow builds the SRPM but skips the COPR submission (existing behavior).