refactor: code cleanup and streamlining#767
Open
dacrab wants to merge 1 commit into
Open
Conversation
- Add toggle_sub_menu helper to Settings, replacing 7 duplicate blocks - Remove dead code: ActiveConnectionState enum, WiredDevice proxy trait - Fix sort allocation: use (u8, &str) tuple key instead of format!() - Combine duplicate match arms in niri.rs - Change launcher.rs API from String to &str, eliminating unnecessary .to_string()/.clone() at 16 call sites - Extract connection_id helper in network/dbus.rs, replacing 3 duplicate extraction chains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanical cleanup: removes dead code, eliminates duplication, and reduces unnecessary allocations. Net result: -82 lines.
Changes
toggle_sub_menu()helper toSettingsActiveConnectionStateenum#[allow(unused)])WiredDeviceproxy trait(u8, &str)tuple keylauncher.rsAPI:String→&str.to_string()/.clone()callsconnection_id()helperTesting
cargo check✓cargo clippy -- -D warnings✓ (zero warnings)