New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1LP][RFR] Automate test for help menu #7418

Merged
merged 2 commits into from Jul 4, 2018

Conversation

Projects
None yet
4 participants
@valaparthvi
Contributor

valaparthvi commented Jul 2, 2018

Add a new test case to check if editing items in the help menu actually updates the help menu.
{{ pytest: cfme/tests/configure/test_help_menu.py }}

Note: This test runs and passes successfully on my local environment, but fails here, since my gpg key hasn't been merged into cfme-qe-yamls yet.

@valaparthvi valaparthvi changed the title from [WIPTEST]Automate test for help menu to [RFR]Automate test for help menu Jul 2, 2018

@dajoRH dajoRH removed the WIP-testing label Jul 2, 2018

@@ -0,0 +1,11 @@
import fauxfactory
from cfme.utils.appliance.implementations.ui import navigate_to

This comment has been minimized.

@quarckster

quarckster Jul 3, 2018

Member

REQUIRED
Please follow our style guides http://cfme-tests.readthedocs.io/en/master/guides/dev_guide.html#code-style.

In addition to being broken up into the three sections of standard library, third-party, and the local application, imports should be sorted alphabetically. ‘import’ lines within those sections still come before ‘from ... import’ lines:

Just put a blank line between third-party and the local imports.

from cfme.utils.appliance.implementations.ui import navigate_to
def test_update_help_menu(appliance):

This comment has been minimized.

@quarckster

@quarckster quarckster changed the title from [RFR]Automate test for help menu to [1LP][WIP] Automate test for help menu Jul 3, 2018

@dajoRH dajoRH added the WIP label Jul 3, 2018

@valaparthvi

This comment has been minimized.

Contributor

valaparthvi commented Jul 3, 2018

My bad! I didn't take a look at the guideline. But, I've updated the changes now.

@quarckster quarckster changed the title from [1LP][WIP] Automate test for help menu to [1LP][RFR] Automate test for help menu Jul 3, 2018

@dajoRH dajoRH removed the WIP label Jul 3, 2018

valaparthvi added some commits Jun 25, 2018

@psav psav merged commit 8074d65 into ManageIQ:master Jul 4, 2018

3 of 4 checks passed

ci/downstream-510z failure #24907
ci/downstream-59z success #24907
code/lint Lint check succeeded.
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@valaparthvi valaparthvi deleted the valaparthvi:help_menu branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment